File the inequality change under the release that contains it - #1037
Merged
Conversation
The entry for polynomial inequalities of degree three and up sits under '2.3.0 -- since 2.2.0'. It merged as #1017 today, after v2.3.0 was tagged, and git show v2.3.0:BREAKING-CHANGES.md does not contain it -- so the file tells a reader the change shipped in a release that does not have it, which is the one thing this file exists to get right. Moved verbatim to Unreleased, both the at-a-glance row and the prose section. Sorting the whole file before and after gives an identical multiset of lines: nothing is added, reworded or lost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING-CHANGES.mdrecords the polynomial-inequality change under## 2.3.0 — since 2.2.0.It merged today as #1017, after
v2.3.0was tagged:So the file tells a reader that
"x ^ 3 - x > 0".Solve("x")changed in 2.3.0, and anyone whoinstalls 2.3.0 to check will find it refusing exactly as before. Recording which release an answer
moved in is the one thing this file exists to get right — its own preamble says every entry gives
"the value on the previous release and the value now, both measured on a build".
What changed
The at-a-glance row and the
### A polynomial inequality of degree three or more is answeredsectionmove verbatim from
## 2.3.0to## Unreleased — since 2.3.0. No wording changes.Verified rather than eyeballed — sorting the whole file before and after gives an identical multiset
of lines, so nothing was added, reworded or lost in the move:
Merge order
BREAKING-CHANGES.mdis also edited by #1025 and #1033, both of which add to## Unreleased.Whichever merges later pays one mechanical conflict round; this one only moves an existing block, so
resolving it is keeping both sides.