Repository navigation
Revert "nvme: apple: restart a pre-M4 ANS that the previous stage left running" - #25
Merged
Merged
Conversation
…t running" On the M2 (T8112) with aura Stage 1, every boot reaches U-Boot with ANS running, because Stage 1 reads the ESP and leaves the coprocessor up. The restart path from that change times out in apple_rtkit_boot twice (-110) and the NVMe probe fails, on cold boots as well as warm ones. The previous U-Boot boots the same machine from the same state. Revert until a recovery is proven on pre-M4 hardware. Assisted-by: LLM Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #23. It stops the M2 (T8112) from booting.
With aura Stage 1, every boot reaches U-Boot with ANS still running, because Stage 1 reads the ESP and doesn't shut the coprocessor down. On U-Boot 2026.07-g368465ece17f (aurora-wip + #23 + #22), the M2 shows this on a warm reboot and on two cold boots in a row:
It then drops to the prompt with no disk. The previous U-Boot (2409ad5) boots the same machine from a cold start. #23's earlier pass was on the Neo, which never takes this path. A replacement that resets the ANS power domain is in progress, and it needs a tethered test on an M1 or M2 before it lands.
🤖 Generated with Claude Code