[codex] Preserve seeded file-order reproducibility when randomizing test runs#3463
Draft
bpc-oss wants to merge 2 commits into
Draft
[codex] Preserve seeded file-order reproducibility when randomizing test runs#3463bpc-oss wants to merge 2 commits into
bpc-oss wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a reproducibility bug in seeded test-file randomization.
When
--randomizeor--seedis used, file ordering should be determined by the explicit file set plus the seed. Before this change, AVA still appliedfailingTestsFirst()before shuffling files. Since that cache-based reordering changes the input array, the same seed could produce a different file order after previous failures updatednode_modules/.cache/ava/failing-tests.json.This patch:
failingTestsFirst()when randomization is activeWhy
Issue
#595explicitly asks for randomization that remains reproducible for debugging. Hidden cache state should not change the order produced by a given seed.Validation
npx xo lib/api.js test-tap/integration/assorted.js$env:CI='1'; npx tap test-tap/integration/assorted.jsnpx tap test-tap/runner.jsnode:24.15.0-bookwormwith the repo extracted at/tmp/ava/ava:npx tap test-tap/reporters/default.js./scripts/test.sh./scripts/ci.shNotes
failingTestsFirst().