Repository navigation
ci(maintenance): add aggregate unit-test check for branch protection - #5567
Merged
Merged
Conversation
…ned PRs The unit test workflow fans out to 30 jobs, so requiring each context individually is brittle: adding a Node.js version or a workspace silently changes which checks are required. `unit-tests-complete` gives branch protection one stable context to require instead. `if: always()` plus the explicit result check is deliberate. A skipped job reports its check run as `skipped`, and GitHub counts a skipped required check as satisfied, so an aggregate job that skipped on failure would green-light a broken PR. Adding `reopened` keeps that context from being stranded: without it a reopened PR never re-reports.
dreamorosi
approved these changes
Aug 19, 2026
dreamorosi
left a comment
dreamorosi
left a comment
Contributor
There was a problem hiding this comment.
Good idea - never thought of this
Closed
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unit tests and
dependency-reviewdon't gate merges onmaintoday, so a pull request can merge with failing tests. This adds a single aggregate context that branch protection can require, and makes sure it always reports.Requiring the 30 individual
code-qualitymatrix contexts instead would be brittle: adding a Node.js version or a workspace silently changes which checks are required.Changes
unit-tests-completejob toreusable-run-linting-check-and-unit-tests.ymlthatneedsall five existing jobs and fails if any of them did not succeedskippedas a failure alongsidefailureandcancelled, and run the job withif: always(). Both are load-bearing: a skipped job reports its check run asskipped, and GitHub counts a skipped required check as satisfied, so an aggregate job that skipped when a dependency failed would green-light a broken pull requestreopenedtopr-run-linting-check-and-unit-tests.ymltriggers, so a reopened pull request re-reports instead of stranding the required contextdependency-review.ymlneeds no change: it triggers on barepull_requestand has nopaths:filter, so it always reports.Follow-up for a repo admin once this merges: add
run-unit-tests / unit-tests-completeanddependency-reviewto the required status checks formain. A context must report at least once before it can be required, which is why this is a separate step.Issue number: closes #5569
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.