Skip to content

fix(L1): validate Nitro validator address - #405

Merged
leopoldjoy merged 1 commit into
mainfrom
fix/tee-registry-nitro-validator-zero-address
Aug 18, 2026
Merged

fix(L1): validate Nitro validator address#405
leopoldjoy merged 1 commit into
mainfrom
fix/tee-registry-nitro-validator-zero-address

Conversation

@leopoldjoy

Copy link
Copy Markdown
Contributor

Summary

  • reject a zero NITRO_VALIDATOR when deploying TEEProverRegistry
  • bump the registry patch version to 0.6.1 and regenerate ABI/semver snapshots
  • use nonzero mock validators in no-Nitro development and test deployments while retaining SystemDeploy validation coverage

Addresses internal audit finding L-01.

Testing

  • just test (1,207 passed, 1 skipped)
  • just test --match-path test/L1/proofs/TEEProverRegistry.t.sol
  • just test --match-path test/L1/proofs/TEEVerifier.t.sol
  • just test --match-path test/deploy/SystemDeploy.t.sol
  • just lint
  • just snapshots

Baseline note

just pre-pr is currently blocked by a lite-profile stack-too-deep error while compiling test/deploy/SystemDeploy.t.sol; the same failure reproduces on origin/main.

Co-authored-by: OpenCode <opencode-noreply@coinbase.com>
@cb-heimdall

cb-heimdall commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@leopoldjoy
leopoldjoy merged commit 8897196 into main Aug 18, 2026
6 checks passed
@leopoldjoy
leopoldjoy deleted the fix/tee-registry-nitro-validator-zero-address branch August 18, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants