fix(L1): reject proof games for not-yet-reached L2 timestamps - #406
Merged
Conversation
`AggregateVerifier.initializeWithInitData` pinned `scheduleId` from the claimed L2 block's deterministic timestamp without requiring that timestamp to have passed on L1. Because post-Fjord batch validation allows an L2 timestamp up to 1800s ahead of its L1 origin, a modified sequencer could open a game pinning an activation that `ProtocolVersions` still allowed the owner to clear or delay, leaving the game permanently bound to a schedule the canonical chain rolled back. Requiring the claim timestamp to be at or before the L1 block timestamp closes that window, since an activation becomes immutable once L1 reaches it. Cantina finding #21. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
✅ Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
AggregateVerifierinitialization when the deterministic timestamp of the claimed L2 block is later than L1block.timestamp. This prevents a game from pinning aProtocolVersionsactivation that can still be cleared or delayed, fixing Cantina finding #21.Notes to reviewers
activatedScheduleIdis read. Once L1 reaches the claim timestamp,ProtocolVersionsprevents changes to that activation.AggregateVerifierABI and semver-lock snapshots for the new error.How has it been tested?
just test— 1208 passed, 0 failed, 1 skipped.