Keep library scans quiet by default#916
Open
Bortlesboat wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Scanner::newquiet by default for library consumerswith_open_port_output()opt-in used by the CLIprintln!with debug loggingWhy
Scanner::run()returns its discovered sockets, but it also printed each open socket directly to stdout. That made the library difficult to embed in applications that own their output. Keeping output disabled on a normal library-created scanner lets callers use the return value without unsolicited stdout, while the RustScan binary explicitly opts into the existing incremental display.Fixes #706.
Validation
cargo test scanner::tests— 11 passedcargo clippy --all-targets -- -D warningscargo fmt --all -- --checkgit diff --checkThe complete
cargo testinvocation entered the repository's network/timing integration tests and exceeded a two-minute local command limit without reporting a failure; the full scanner unit suite completed successfully.