feat: enable mini apps (devmode only) - #1882
Merged
Merged
Conversation
Home page tiles for IDconvert and SmartPrism previously either did nothing in production (server gated on DEVMODE) or fell back to selecting a pre-rendered hidden nav panel. Both are now launched on demand via launchModule()/nav_insert(), matching the pattern already used for Qsee and Across: - server.R: add launch_idconvert()/launch_prism(), register them in app_launchers - launcher_server.R: launch_idconvert/launch_prism handlers now call into app_launchers instead of bslib::nav_select() on a static panel - ui.R: drop the now-redundant static nav_panel_hidden() blocks for IDconvert and Prism Also, while wiring this up: - prism_ui.R, board_mofa_ui.R: add padding = 0 to their bslib::page_fillable() roots (idconvert_ui.R/qsee_ui.R already did this) so bslib's default 1rem page padding doesn't show as a thick white border - prism_server.R: fix a crash on first launch -- get_plotcode()'s eager observe() ran before the client had sent chartbot_user_input, so isolate(input$chartbot_user_input) == "" compared NULL == "" and threw "argument is of length zero"; this module's server was never actually wired up before now, so the bug was latent
ivokwee
marked this pull request as draft
September 1, 2026 19:07
ivokwee
changed the title
ivokwee
marked this pull request as ready for review
September 2, 2026 11:31
ivokwee
changed the title
ivokwee
changed the title
ivokwee
changed the title
ESCRI11
self-requested a review
September 10, 2026 07:38
ESCRI11
approved these changes
Sep 10, 2026
Server-side selectize defaults to maxOptions=1000, silently truncating the ~1581 species list without this option. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
launchModule()/nav_insert()pattern already used for Qsee/Across, so their Home page tiles actually launch the module on click instead of doing nothing (IDconvert/Prism servers were never attached) or selecting a static pre-rendered panel.nav_panel_hidden()blocks for IDconvert/Prism fromui.R.padding = 0to Prism's and MOFA'sbslib::page_fillable()roots (IDconvert/Qsee already had this) so bslib's default 1rem page padding doesn't render as a thick white border around the module.prism_server.R:get_plotcode()'s eagerobserve()fired before the client sent backchartbot_user_input, soisolate(input$chartbot_user_input) == ""comparedNULL == "", producinglogical(0)and anif (argument is of length zero)error that killed the whole session. This was latent sinceprism_server()was never actually called before this PR.Test plan
shiny::testServer(prism_server, ...): initial reactive flush and an emptychartbot_user_inputboth complete without errorNOTE
This need first playbase PR bigomics/playbase#504 (bridge-ortholog) to be merged.