Build on robot broken due to #1012

[jgueldenstein]

Summary

#1012 indroduced flags to fail compilation when warnings exist, but the zed camera ros interface throws some warnings, this pr was apparently not tested on the robot because the build fails.

[jgueldenstein]

simply running pixi run -e robot colcon build --symlink-install on the robot works

[MegaIng]

IIRC these warnings are only present on some robots, so even if it was tested it may have passed.

But I knew that these warnings may exists and forgot about it when reviewing :-(

[jgueldenstein]

@jaagut @MegaIng any updates on this?

[MegaIng]

/usr/local/zed/include/sl/Camera.hpp:1295:20: error: ISO C++ prohibits anonymous structs [-Werror=pedantic]
 1295 |             struct {

Also present for quite a few other anonymous structs.

/usr/local/zed/include/sl/Camera.hpp:1916:33: error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]
 1916 |         _FCT_CPU_GPU_ Vector3<T>(const Vector3<T> &v) {

Easy fix, just remove the paramter. Also present a few more times.

/usr/local/zed/include/sl/Camera.hpp:2731:16: error: implicitly-declared 'constexpr sl::Timestamp::Timestamp(const sl::Timestamp&)' is deprecated [-Werror=deprecated-copy]
 2731 |         return lhs;
      |                ^~~
/usr/local/zed/include/sl/Camera.hpp:2647:20: note: because 'sl::Timestamp' has user-provided 'sl::Timestamp& sl::Timestamp::operator=(sl::Timestamp)'
 2647 |         Timestamp& operator=(Timestamp other) {

This exact same error appears once for each invocation of the copy constructor. But there are also other classes that have this issue.

/usr/local/zed/include/sl/Camera.hpp:2782:89: error: unused parameter 'file' [-Werror=unused-para
meter]
 2782 |     static inline cudaError __cudaSafeCall(cudaError err, const char *func, const char *file, const int line) {
      |                                                                             ~~~~~~~~~~~~^~~~
/usr/local/zed/include/sl/Camera.hpp:2782:105: error: unused parameter 'line' [-Werror=unused-parameter]
 2782 |     static inline cudaError __cudaSafeCall(cudaError err, const char *func, const char *file, const int line) {
      |                                                                                               ~~~~~~~~~~^~~~

/home/bitbots/bitbots_main/src/lib/zed-ros2-wrapper/zed_components/src/tools/src/sl_tools.cpp:257:10: error: enumeration value 'U16_C1' not handled in switch [-Werror=switch]
  257 |   switch (dataType) {
      |          ^
/home/bitbots/bitbots_main/src/lib/zed-ros2-wrapper/zed_components/src/tools/src/sl_tools.cpp:257:10: error: enumeration value 'S8_C4' not handled in switch [-Werror=switch]

Unclear what the fix for these is. These appear to be part of their communcation protocol?

/home/bitbots/bitbots_main/src/lib/zed-ros2-wrapper/zed_components/src/tools/src/sl_tools.cpp:309
:21: error: comparison of integer expressions of different signedness: 'int' and 'size_t' {aka 'long unsigned int'} [-Werror=sign-compare]
  309 |   for (int i = 0; i < left.getHeight(); i++) {
      |                   ~~^~~~~~~~~~~~~~~~~~

/home/bitbots/bitbots_main/src/lib/zed-ros2-wrapper/zed_components/src/tools/src/sl_tools.cpp: In function 'std::string sl_tools::getSDKVersion(int&, int&, int&)':
/home/bitbots/bitbots_main/src/lib/zed-ros2-wrapper/zed_components/src/tools/src/sl_tools.cpp:132:17: error: this statement may fall through [-Werror=implicit-fallthrough=]
  132 |       sub_minor = std::stoi(strings[2]);
      |       ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
/home/bitbots/bitbots_main/src/lib/zed-ros2-wrapper/zed_components/src/tools/src/sl_tools.cpp:134:5: note: here
  134 |     case 2:
      |     ^~~~

/home/bitbots/bitbots_main/src/lib/zed-ros2-wrapper/zed_components/src/tools/src/sl_tools.cpp:254:10: note: 'srcL' was declared here
  254 |   char * srcL;
      |          ^~~~
/home/bitbots/bitbots_main/src/lib/zed-ros2-wrapper/zed_components/src/tools/src/sl_tools.cpp:312:11: error: 'srcR' may be used uninitialized [-Werror=maybe-
uninitialized]
  312 |     memcpy(dest, srcR, right.getStepBytes());
      |     ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/bitbots/bitbots_main/src/lib/zed-ros2-wrapper/zed_components/src/tools/src/sl_tools.cpp:255:10: note: 'srcR' was declared here
  255 |   char * srcR;
      |          ^~~~

Related to missing some enum values.

---

Some of these are not part of the headers we are vendoring currently, so I am going to open a PR to revert -Werror so that we can build on the robots again.