buzz-acp: add structured MCP server configuration - #4164
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9e32d5848
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
#4301 now describes the broader portable-agent lifecycle using Buzz's existing agent, template, connection, version and snapshot concepts. This PR remains the first narrow slice: structured, named MCP configuration in |
9cc1104 to
8c99312
Compare
8c99312 to
85ef19f
Compare
Signed-off-by: KC <79471844+wolfyy970@users.noreply.github.com>
Signed-off-by: KC <79471844+wolfyy970@users.noreply.github.com>
Signed-off-by: KC <79471844+wolfyy970@users.noreply.github.com>
Signed-off-by: KC <79471844+wolfyy970@users.noreply.github.com>
Signed-off-by: KC <79471844+wolfyy970@users.noreply.github.com>
Signed-off-by: KC <79471844+wolfyy970@users.noreply.github.com>
85ef19f to
dbf1cc4
Compare
|
@tlongwell-block @wpfleger96, @custard-pirate and I agree on the MCP split: #4164 owns the versioned document and stdio transport; #4271 adds HTTP to that schema. #4480 can then use the same document for live changes instead of adding a third config format. That leaves Buzz with one MCP configuration surface and one compatibility input. Could one of you confirm this ownership split? If so, I will keep #4164 at that boundary and help adapt #4271 to it. |
Signed-off-by: KC <79471844+wolfyy970@users.noreply.github.com>
…cp-servers Signed-off-by: KC <79471844+wolfyy970@users.noreply.github.com>
…cp-servers Signed-off-by: KC <79471844+wolfyy970@users.noreply.github.com>
…cp-servers Signed-off-by: KC <79471844+wolfyy970@users.noreply.github.com>
Summary
This moves an agent's MCP tool set out of one opaque command and into a versioned, reviewable config. The same setup can be reproduced across agents and machines, and operators can see what will run before giving it credentials.
buzz-acpnow accepts multiple named MCP servers through--mcp-configorBUZZ_ACP_MCP_CONFIG. Version 1 supportsstdioand preserves each server's name, command, arguments, order and environment without shell parsing. Invalid config stops startup.The existing
BUZZ_ACP_MCP_COMMANDpath is unchanged and remains first when both inputs are present. The transport tag lets #4271 add HTTP without introducing another config format.MCP environment values are redacted from wire logs, observer events, diagnostics and returned adapter errors.
Fixes #4154.
Boundary
Structured servers receive only their declared environment in the ACP request. The adapter still inherits the harness environment and launches the MCP processes, so this is explicit configuration, not process isolation.
Validation
cargo test -p buzz-acp --no-fail-fast(697 unit tests, 10 integration tests)cargo clippy -p buzz-acp --all-targets -- -D warningscargo fmt -p buzz-acp -- --check