Run first host health check immediately and apply health state on registration + fix CI by upgrading CMake version - #89
Merged
Conversation
Rahmeen14
marked this pull request as ready for review
August 11, 2026 13:57
Rahmeen14
enabled auto-merge (squash)
August 11, 2026 14:25
Rahmeen14
disabled auto-merge
August 11, 2026 14:25
Rahmeen14
force-pushed
the
host-health-immediate-check
branch
2 times, most recently
from
August 12, 2026 14:44
8363a74 to
96641d0
Compare
Rahmeen14
force-pushed
the
host-health-immediate-check
branch
from
August 12, 2026 14:49
96641d0 to
cafdd7f
Compare
Rahmeen14
marked this pull request as draft
August 13, 2026 16:09
Rahmeen14
marked this pull request as ready for review
August 14, 2026 13:03
flamble
previously approved these changes
Aug 14, 2026
| scheduleNextCheck(); | ||
| // Fire the first check immediately; checkHealth() then reschedules at | ||
| // pollInterval. | ||
| d_timer->reset(bsls::TimeInterval(0)); |
Contributor
There was a problem hiding this comment.
I noticed a docs discrepancy when checking the docs on this call.
The (existing) docs for reset say "It is invalid to call reset without calling start first." which we're not doing with this d_timer.
However, it's created with createWithCallback , which says "The timer should be started by calling reset()."
We should address this discrepancy in a future PR.
Co-authored-by: Freddie <flamble@gmail.com> Signed-off-by: Rahmeen Habib <rahmeenwill99@gmail.com>
Rahmeen14
enabled auto-merge (squash)
August 14, 2026 19:33
flamble
previously approved these changes
Aug 14, 2026
flamble
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
HostHealthMonitorpreviously waited a fullpollIntervalbefore its first health check and didn't remember the health state, so consumers could start consuming before the host was verified, and a connection registering while the host was unhealthy would wait until the next poll to pause. This makes the first check immediate, caches the state and applies it on registration, and improves the health logging.Changes
start()arms the timer with a zero delay, so the first check fires on the event loop right away instead of after a fullpollInterval;checkHealth()reschedules subsequent checks atpollInterval.UNHEALTHYuntil the first check completes, so consumers don't consume from an unverified host.registerConnectionbrings a connection into the current known state immediately: resumed if the host is known healthy (consumers start active without waiting for the next poll), paused if unhealthy. Each subsequent poll re-applies the latest state to every registered connection, so a consumer created at any point opens in the current known state.event=health-state-changed …); per-check outcomes are DEBUG to avoid steady-state noise. Health log lines usefield=valueformat for aggregation.string(JSON..STRING_ENCODE), which was added in CMake 4.3. Install a modern CMake from PyPI (arch-independent) so vcpkg dependency builds succeed.