Feature/optional tests - #90
Open
nsoblath wants to merge 2 commits into
Open
Conversation
… built Signed-off-by: Noah Oblath <nsoblath@gmail.com>
…fault is still on. Tie vcpkg manifest setting to the CMake setting. Signed-off-by: Noah Oblath <nsoblath@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem statement
This PR addresses the inability to build rmqcpp without the tests and the GTest dependency. This was requested in #69.
Proposed changes
I introduced a CMake option,
rmqcpp_ENABLE_TESTINGto control the building of tests and finding of GTest in CMake. From the vcpkg side I moved thegtestdependency to a feature that's enabled by default. To connect the vcpkg side to the CMake side, an additional CMake variable,rmqcpp_ENABLE_TESTING_DEFAULT, controls the default value ofrmqcpp_ENABLE_TESTING.If building directly with CMake, the option can be set with
-Drmqcpp_ENABLE_TESTINGwhencmakeis called. If building with vcpkg manifest mode, these are the different options that can be used:Testing is enabled by default for backwards compatibility.
Remaining work