Repository navigation
Conversation
|
Initial automated review · Aster Hi @0xBora, thanks for the PR! 🙏 This is an automatic first check by an AI reviewer. It does not replace maintainer review and may be wrong. Reviewed commit: No issues found in this first check. Not tested: Tests and live DuckDB queries were not run; the Clean, Build workflow reports |
0xBora
force-pushed
the
fix/gov-proposal-query-hints
branch
from
October 27, 2026 16:04
eff1ab5 to
b058887
Compare
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The
gov_action_proposalquery hint lists'PARAMETER_CHANGE','HARD_FORK_INITIATION'and'TREASURY_WITHDRAWALS', but the column stores theGovActionTypenames, which end in_ACTION. A query that follows the hint, such asWHERE type = 'TREASURY_WITHDRAWALS', returns no rows. This is one of the items reported in #913.This PR:
GovActionType;GovActionTypevalue is missing from the hint.Checked against mainnet data on a Yaci Store analytics instance:
SELECT type, count(*) FROM gov_action_proposal GROUP BY typereturnsTREASURY_WITHDRAWALS_ACTION,INFO_ACTION,PARAMETER_CHANGE_ACTION,NEW_CONSTITUTION,UPDATE_COMMITTEEandHARD_FORK_INITIATION_ACTION.