Skip to content

fix(analytics): list stored gov action type values in the query hint - #1304

Open
0xBora wants to merge 1 commit into
bloxbean:mainfrom
0xBora:fix/gov-proposal-query-hints
Open

0xBora wants to merge 1 commit into
bloxbean:mainfrom
0xBora:fix/gov-proposal-query-hints

Conversation

@0xBora

@0xBora 0xBora commented Oct 27, 2026 •

Copy link
Copy Markdown

The gov_action_proposal query hint lists 'PARAMETER_CHANGE', 'HARD_FORK_INITIATION' and 'TREASURY_WITHDRAWALS', but the column stores the GovActionType names, which end in _ACTION. A query that follows the hint, such as WHERE type = 'TREASURY_WITHDRAWALS', returns no rows. This is one of the items reported in #913.

This PR:

  • lists all seven stored values, taken from GovActionType;
  • adds a test that fails if a GovActionType value is missing from the hint.

Checked against mainnet data on a Yaci Store analytics instance: SELECT type, count(*) FROM gov_action_proposal GROUP BY type returns TREASURY_WITHDRAWALS_ACTION, INFO_ACTION, PARAMETER_CHANGE_ACTION, NEW_CONSTITUTION, UPDATE_COMMITTEE and HARD_FORK_INITIATION_ACTION.

Copy link
Copy Markdown

Initial automated review · Aster

Hi @0xBora, thanks for the PR! 🙏 This is an automatic first check by an AI reviewer. It does not replace maintainer review and may be wrong.

Reviewed commit: dd73be51bc134f9850303be2f9d42622ed5d7bc4

No issues found in this first check.

Not tested: Tests and live DuckDB queries were not run; the Clean, Build workflow reports action_required with no jobs.

@0xBora 0xBora changed the title fix(analytics): list stored gov action type values in the query hint fix(analytics): correct the gov_action_proposal query hints Oct 27, 2026
@0xBora
0xBora force-pushed the fix/gov-proposal-query-hints branch from eff1ab5 to b058887 Compare October 27, 2026 16:04
@0xBora 0xBora changed the title fix(analytics): correct the gov_action_proposal query hints fix(analytics): list stored gov action type values in the query hint Oct 27, 2026
@sonarqubecloud

Copy link
Copy Markdown

@satran004 satran004 added this to the 3.0.0-beta6 milestone Oct 29, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants