ライブラリコードと検証コードを近くに配置する - #14
Merged
Merged
Conversation
Co-authored-by: blue-jam <9583566+blue-jam@users.noreply.github.com> Agent-Logs-Url: https://github.com/blue-jam/ProconLibrary/sessions/f209cf78-f088-430d-b1fb-7b139438175e
Copilot
AI
changed the title
[WIP] Place verification code next to library code
ライブラリコードと検証コードを近くに配置する
Mar 24, 2026
Owner
|
@copilot lintが落ちているから直して |
Co-authored-by: blue-jam <9583566+blue-jam@users.noreply.github.com> Agent-Logs-Url: https://github.com/blue-jam/ProconLibrary/sessions/e3610f7b-c3a8-440f-9e74-a71d30b21fc0
Contributor
Author
blue-jam
marked this pull request as ready for review
March 24, 2026 21:17
blue-jam
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
検証コードが
verify/ディレクトリに集約されており、対応するライブラリとの関係が分かりにくかった。検証コードを対応するライブラリと同じディレクトリに移動し、{ライブラリ名}.{問題ID}.test.cppの形式で命名する。ファイルの移動・リネーム
31個のテストファイルを
verify/から各ライブラリディレクトリへ移動:graph/dijkstra.grl_1_a.test.cpp,kruskal.grl_2_a.test.cppdatastructure/fenwick.dsl_2_b.test.cpp,lazysegtree.aoj1351.test.cppgeometry/crosspoint.cgl_2_b.test.cpp,arrangement.aoj1279.test.cpp複数ライブラリを使うテストは、最も本質的なライブラリのディレクトリに配置(例:
aoj1279は arrangement + dijkstra を使うがgeometry/arrangement.aoj1279.test.cppとして配置)。CMakeLists.txtの更新VERIFY_SOURCESのグロブをverify/*.test.cppから各ライブラリディレクトリの*.test.cppに変更ALL_SOURCES(lint 対象)も同様に更新get_filename_componentをNAME_WEからNAME_WLEに変更 — 新しいファイル名は複数のドットを含むため、NAME_WEでは最初のドット以降がすべて除去され CMake ターゲット名が重複するverify/src/配下の非テストファイルは変更なし。Original prompt
⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.