Conversation
A couple of files that each stay under the spool threshold can still add up past 100 KiB and raise MultipartError. Keep MEMFILE_MAX as the per-part limit and scale the parser-wide cap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1470
MEMFILE_MAX is the per-part spool threshold, but 0.13 also passed it as the parser-wide memory cap. Two files of 60 KiB each then hit Memory limit reached even though each one would have been fine on its own.
Keep MEMFILE_MAX as memfile_limit and set mem_limit to MEMFILE_MAX * 128, which is what the discussion on the issue landed on for a total that still scales if an app lowers or raises the setting.