Repository navigation
fix(storage): use unique local provider identities - #83
Merged
Merged
Conversation
sirdeggen
added a commit
that referenced
this pull request
Sep 24, 2026
#83 (codex/local-storage-sync-state), brought up to date with master: the PR's older dependency pins and lockfile were dropped in favour of master's, and end-to-end tests were added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@bsv/sdk2.4.1 and wallet-toolbox/client 2.10.2 APIsRoot cause
BSV Desktop used the wallet identity as the local storage provider identity. Remote storage keys sync checkpoints by provider identity, so another app or database using that same wallet identity could create multiple sync-state rows for one provider key. A later
processSyncChunklookup then failed withResult must exist and be unique.The migration replaces only the local database's provider identity and any local active-storage pointer that still references the legacy value. The remote provider remains primary for remote-first wallets.
The complementary server/protocol hardening is in bsv-blockchain/ts-stack#486.
Compatibility
Validation
npm test: 15 passednpm run build: passednpm run build:electron: passedprocessSyncChunkcalls without reproducing the ambiguous-result error or HTTP 413This remains a draft pending review and completion of broader large-wallet UX/performance validation.