fix(overlay-topics): read the uora anchor output exactly - #512
Merged
Merged
Conversation
readUoraAnchor reads the script's chunks instead of PushDrop.decode, refusing a locking key push that is not 33 bytes, a drop tail that is not exactly the drops the fields need, and a field carrying a control character, as the format's reference reader does. No published anchor uses any of these shapes. The shared fixture gains the uncompressedKey and malformedTail vectors that pin the first two, and the suite covers each refusal and the admission path.
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
ty-everett
marked this pull request as ready for review
September 15, 2026 19:39
ty-everett
requested review from
BraydenLangley,
sirdeggen,
tonesnotes and
ty-everett
as code owners
September 15, 2026 19:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Program and scope
Align the UORA v3 reader with the versioned format: compressed locking keys, exact drop tails and printable UTF-8 fields. Preserve valid anchor bytes, signatures, topic membership, exports and lookup shapes. Document coordinated reader upgrades and review previously indexed nonconforming outputs before rebuilding the topic.
Impact
Verification
pnpm health:check,pnpm lint,pnpm format:check, fullpnpm build,pnpm typecheck, andpnpm audit:securitypassed.Security and dependencies
Release and operations