Conversation
…gstenite async-tungstenite 0.32 includes a built-in bytes module with ByteReader and ByteWriter types that provide tokio::io::AsyncRead/AsyncWrite over WebSocket streams. This makes the ws_stream_tungstenite crate redundant, and that crate pins async-tungstenite ^0.29, blocking the upgrade. Changes: - Update async-tungstenite from 0.29 to 0.32 - Remove ws_stream_tungstenite dependency - Add a custom WsStream adapter in websockets.rs that wraps async-tungstenite's ByteReader/ByteWriter to provide tokio IO traits - Add futures-io and pin-project-lite as optional websocket dependencies - Update v4 and v5 eventloop imports accordingly
|
Would you (or anyone reading) happen to have a reference or use case for supporting |
|
Also noting that the dependency tree does include |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
async-tungstenite 0.32 includes a built-in bytes module with ByteReader and ByteWriter types that provide tokio::io::AsyncRead/AsyncWrite over WebSocket streams. This makes the ws_stream_tungstenite crate redundant, and that crate pins async-tungstenite ^0.29, blocking the upgrade.
Changes:
Type of change
Checklist:
cargo fmtCHANGELOG.mdif it's relevant to the users of the library. If it's not relevant mention why. - Not relevant, this is an internal implementation detail.