Repository navigation
Add char, variant and flags component values - #384
Merged
martindevans merged 1 commit intoOct 11, 2026
Merged
martindevans merged 1 commit into
martindevans merged 1 commit into
Conversation
phillipcaofph
force-pushed
the
add-var-variant-flag-component-values
branch
from
October 11, 2026 01:55
8d3afd1 to
1d4e2fd
Compare
martindevans
approved these changes
Oct 11, 2026
martindevans
left a comment
martindevans
left a comment
Member
There was a problem hiding this comment.
Looks good! I'm happy to merge as-is if you don't think the overloads I mentioned are worthwhile/feasible to implement.
Support validated Unicode scalars and named variants and flags in the component value API. Marshal caller-owned arguments and Wasmtime-owned callback results with the correct native layouts and allocation ownership. Add boundary, nested-value, owned-allocation and native clone tests.
phillipcaofph
force-pushed
the
add-var-variant-flag-component-values
branch
from
October 11, 2026 20:52
1d4e2fd to
4044981
Compare
martindevans
approved these changes
Oct 11, 2026
Member
|
Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the rest of the simpler component value types. Resource and Map types remain unsupported.