Repository navigation
docs: reorder README and render architecture diagrams with AWS icons - #308
Merged
Merged
Conversation
cdklabs-automation
enabled auto-merge
October 13, 2026 01:24
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
GitHub's Mermaid renderer can't load icon packs, and npm and Construct Hub don't render Mermaid at all. The diagrams now live as architecture-beta sources in docs/diagrams/, rendered to SVG with the Iconify logos AWS icons by `pnpm diagrams`; `pnpm test` fails when an SVG's source hash is stale.
- R1-1: stamp covers the mmdc and icon pack versions; icon pack exact-pinned out of upgrade-dev-deps - R1-2: diagrams:check fails on an SVG with no .mmd source - R1-3: run npx through a shell on Windows - R1-5: script header describes the hash check, not file age
Contributor
Author
pr-review summaryConverged in 1 round (FULL review of
Fixes (16df895), all in
Escalations
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README reorder
Moves sections only; no content changes.
Anchors still work. Each "above"/"below" reference points within its own section.
Architecture diagrams with AWS icons
GitHub's Mermaid renderer can't load icon packs, so the
architecture-betadiagrams were stuck with generic server/disk/database icons. npm and Construct Hub don't render Mermaid at all, so those pages showed raw code blocks.docs/diagrams/*.mmd(same diagrams, now usinglogos:aws-*icons from@iconify-json/logos, a new devDependency).pnpm diagramsrenders them to committed SVGs with a pinned@mermaid-js/mermaid-clirun vianpx. It isn't a devDependency, so installs don't pull in Puppeteer and Chrome.pnpm diagrams:checkruns as part oftest. Each SVG is stamped with its source's SHA-256 and the check compares the hashes, so it needs no Chrome. It doesn't diff bytes because Chromium's font layout differs between macOS and Linux.raw.githubusercontent.com/.../mainso they render on npm and Construct Hub.docs/diagrams/is excluded from the tarball.docs/development-guide.md.Review note: the README images point at
main, so the README preview on this PR shows broken images until it merges. View the SVGs underdocs/diagrams/in the Files tab.