Skip to content

docs: reorder README and render architecture diagrams with AWS icons - #308

Merged
bestickley merged 5 commits into
mainfrom
docs/readme-reorder
Oct 13, 2026
Merged

bestickley merged 5 commits into
mainfrom
docs/readme-reorder

Conversation

@bestickley

@bestickley bestickley commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

README reorder

Moves sections only; no content changes.

  1. Features → Why → Design Principles (moved up from the middle, so the pitch is read first)
  2. Prerequisites → Getting Started → Basic Example
  3. Architecture (right after the example, so readers choose a construct before tuning it)
  4. Configuration → Splitting a Large App Across Functions (advanced tuning, next to the other customization sections)
  5. Bring Your Own Resources → Preview Environments → … (unchanged)

Anchors still work. Each "above"/"below" reference points within its own section.

Architecture diagrams with AWS icons

GitHub's Mermaid renderer can't load icon packs, so the architecture-beta diagrams were stuck with generic server/disk/database icons. npm and Construct Hub don't render Mermaid at all, so those pages showed raw code blocks.

  • Sources are in docs/diagrams/*.mmd (same diagrams, now using logos:aws-* icons from @iconify-json/logos, a new devDependency).
  • pnpm diagrams renders them to committed SVGs with a pinned @mermaid-js/mermaid-cli run via npx. It isn't a devDependency, so installs don't pull in Puppeteer and Chrome.
  • pnpm diagrams:check runs as part of test. Each SVG is stamped with its source's SHA-256 and the check compares the hashes, so it needs no Chrome. It doesn't diff bytes because Chromium's font layout differs between macOS and Linux.
  • The README links the SVGs at raw.githubusercontent.com/.../main so they render on npm and Construct Hub. docs/diagrams/ is excluded from the tarball.
  • Workflow documented in docs/development-guide.md.

Review note: the README images point at main, so the README preview on this PR shows broken images until it merges. View the SVGs under docs/diagrams/ in the Files tab.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/@iconify-json/logos 1.2.16 UnknownUnknown
npm/@iconify/types 2.0.0 🟢 4.2
Details
CheckScoreReason
Code-Review🟢 5Found 8/16 approved changesets -- score normalized to 5
Maintained🟢 1030 commit(s) and 6 issue activity found in the last 90 days -- score normalized to 10
Token-Permissions⚠️ -1No tokens found
Packaging⚠️ -1packaging workflow not detected
Dangerous-Workflow⚠️ -1no workflows found
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Pinned-Dependencies⚠️ -1no dependencies found
Binary-Artifacts🟢 10no binaries found in the repo
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Fuzzing⚠️ 0project is not fuzzed
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Security-Policy⚠️ 0security policy file not detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0

Scanned Files

  • pnpm-lock.yaml

GitHub's Mermaid renderer can't load icon packs, and npm and Construct Hub
don't render Mermaid at all. The diagrams now live as architecture-beta
sources in docs/diagrams/, rendered to SVG with the Iconify logos AWS icons
by `pnpm diagrams`; `pnpm test` fails when an SVG's source hash is stale.
@bestickley bestickley changed the title docs: reorder README so pitch leads and configuration follows architecture docs: reorder README and render architecture diagrams with AWS icons Oct 13, 2026
- R1-1: stamp covers the mmdc and icon pack versions; icon pack exact-pinned out of upgrade-dev-deps
- R1-2: diagrams:check fails on an SVG with no .mmd source
- R1-3: run npx through a shell on Windows
- R1-5: script header describes the hash check, not file age
@bestickley

Copy link
Copy Markdown
Contributor Author

pr-review summary

Converged in 1 round (FULL review of c026e1e..822dadb, bugs + spec axes). No high- or medium-severity findings; the spec reviewer found the branch matches the PR description.

Round Range Raw (bugs/spec) Blocking Fixed Escalated
1 FULL 4 / 0 (+1 side note) 0 4 1

Fixes (16df895), all in scripts/render-diagrams.mjs

  • The source stamp now covers the mmdc and @iconify-json/logos versions, not just the .mmd. The icon pack is exact-pinned, which takes it out of the automated upgrade-dev-deps filter, so a version bump is a hand edit that diagrams:check makes you re-render for.
  • diagrams:check now also fails on an SVG whose .mmd was renamed or deleted.
  • npx runs through a shell on Windows, where npx.cmd can't be spawned without one.
  • The header comment describes the hash check (it said "older than its .mmd").

Escalations

  • README images link raw.githubusercontent.com/.../main, so the READMEs of already-published versions on npm and Construct Hub will show the current diagrams. Accepted as is: the diagrams rarely change, and relative links can't work with docs/diagrams/ excluded from the package.

pnpm test: 46 suites, 1131 tests pass; diagrams:check passes.

@bestickley
bestickley disabled auto-merge October 13, 2026 15:08
@bestickley
bestickley merged commit 80fe128 into main Oct 13, 2026
15 checks passed
@bestickley
bestickley deleted the docs/readme-reorder branch October 13, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant