Repository navigation
test: skip the third-parties GTM case that counts Google's live dataLayer events - #315
Merged
Merged
Conversation
…ayer events googletagmanager.com now answers the fixtures' GTM-XYZ with a 200, so Google's script pushes its own events and `renders GTM` sees 3 dataLayer entries instead of 1. It failed on every NextjsType in the 2026-10-13 scheduled harness run. Upstream fixed the test after v16.4.0 (vercel/next.js#99896); move both files to `suites` with that case skipped until the pin includes it. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
cdklabs-automation
enabled auto-merge
October 15, 2026 14:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
googletagmanager.com now answers the fixtures'
GTM-XYZwith a 200 instead of a 404, so Google's script runs and pushes its own events:renders GTMsees 3dataLayerentries instead of 1. It failed both tries on every NextjsType in the 2026-10-13 scheduled harness run (38412496232, all four attempts), with no cdk-nextjs error.Upstream fixed the test after v16.4.0 (vercel/next.js#99896); the harness pins v16.4.0. This moves
third-parties/indexandapp-dir/third-parties/basicfromrules.includetosuiteswith only that case skipped, regenerates the screening counts (screen.mjs --checkpasses), and records the verdict in docs/harness-coverage.md. Drop both entries once the pin includes #99896.Verified with a targeted harness run of just these two files on all four types (
nextjs_type=all,shard_total=1): https://github.com/cdklabs/cdk-nextjs/actions/runs/38747397860 - both files passed on retry 0 everywhere.Not addressed:
app-dir/router-autoscrollfailed both tries on Global Functions shard 1 in attempt 3 (passed in attempts 1-2), a known retry-pass flake; revisit if the next scheduled run repeats it.🤖 Generated with Claude Code