Skip to content

fix: refactor process aggregation to a shared core reader #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdsap merged 1 commit into from
Sep 17, 2026
Merged

fix: refactor process aggregation to a shared core reader #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/kotlin/io/github/cdsap/kotlinprocess/DevelocityWrapperConfiguration.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class DevelocityWrapperConfiguration {

buildScanExtension.buildScan.buildFinished {
val processes =
KotlinProcessCollector().collect(
KotlinProcessReader().read(
providers.jStat.get(),
providers.jInfo.get(),
)
Expand Down
2 changes: 1 addition & 1 deletion src/main/kotlin/io/github/cdsap/kotlinprocess/InfoKotlinProcessBuildService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ abstract class InfoKotlinProcessBuildService :

override fun close() {
val processes =
KotlinProcessCollector().collect(
KotlinProcessReader().read(
parameters.jStatProvider.get(),
parameters.jInfoProvider.get(),
)
Expand Down
4 changes: 2 additions & 2 deletions ...p/kotlinprocess/KotlinProcessCollector.kt → ...dsap/kotlinprocess/KotlinProcessReader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import io.github.cdsap.jdk.tools.parser.ConsolidateProcesses
import io.github.cdsap.jdk.tools.parser.model.Process
import io.github.cdsap.jdk.tools.parser.model.TypeProcess

class KotlinProcessCollector {
fun collect(
class KotlinProcessReader {
fun read(
jStat: String,
jInfo: String,
): List<Process> = ConsolidateProcesses().consolidate(jStat, jInfo, TypeProcess.Kotlin)
Expand Down
20 changes: 10 additions & 10 deletions ...tlinprocess/KotlinProcessCollectorTest.kt → .../kotlinprocess/KotlinProcessReaderTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,33 +5,33 @@ import junit.framework.TestCase.assertEquals
import junit.framework.TestCase.assertTrue
import org.junit.Test

class KotlinProcessCollectorTest {
private val collector = KotlinProcessCollector()
class KotlinProcessReaderTest {
private val reader = KotlinProcessReader()

@Test
fun collectReturnsEmptyListForEmptyRawStrings() {
val processes = collector.collect("", "")
fun readReturnsEmptyListForEmptyRawStrings() {
val processes = reader.read("", "")

assertTrue(processes.isEmpty())
}

@Test
fun collectReturnsEmptyListForBlankRawStrings() {
val processes = collector.collect(" ", "\n")
fun readReturnsEmptyListForBlankRawStrings() {
val processes = reader.read(" ", "\n")

assertTrue(processes.isEmpty())
}

@Test
fun collectReturnsEmptyListWhenRawProcessInfoHasNoMatchingProcesses() {
val processes = collector.collect("xxxx", "yyyy")
fun readReturnsEmptyListWhenRawProcessInfoHasNoMatchingProcesses() {
val processes = reader.read("xxxx", "yyyy")

assertTrue(processes.isEmpty())
}

@Test
fun collectConsolidatesRawProcessInfoAsKotlinTypeProcess() {
val processes = collector.collect(jStatWithPid, jInfoWithPid)
fun readConsolidatesRawProcessInfoAsKotlinTypeProcess() {
val processes = reader.read(jStatWithPid, jInfoWithPid)

assertEquals(1, processes.size)
assertEquals("28743", processes[0].pid)
Expand Down
Loading