Fixed cleanup of stale cfbuild packages on build hosts - #2427
Merged
Conversation
zypper has no uninstall command, so erase-packages silently did nothing on SUSE. The || true guard hid the error. The cleanup also ran too late. It sat inside the cf-remote branch, which the CentOS 6 and SUSE 12 paths never reach because they install the agent directly. Leftover cfbuild-* packages own files under /var/cfengine. Installing cfengine-nova then aborts on file conflicts, because zypper install -y does not auto-answer the file conflict prompt. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Contributor
Author
|
@cf-bottom Jenkins please :) |
This was referenced Aug 13, 2026
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14502/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14502/ |
craigcomstock
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zypper has no uninstall command, so erase-packages silently did nothing on SUSE. The || true guard hid the error.
The cleanup also ran too late. It sat inside the cf-remote branch, which the CentOS 6 and SUSE 12 paths never reach because they install the agent directly.
Leftover cfbuild-* packages own files under /var/cfengine. Installing cfengine-nova then aborts on file conflicts, because zypper install -y does not auto-answer the file conflict prompt.
Signed-off-by: Lars Erik Wik lars.erik.wik@northern.tech
Backported to: