Allow custom publish scripts to complete without a Changesets output file#697
Conversation
🦋 Changeset detectedLatest commit: 0821be0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bluwy
left a comment
bluwy
left a comment
There was a problem hiding this comment.
Was this fixing an issue you were facing?
|
it's something i found: https://discord.com/channels/1499011163705573470/1528323111894909029/1528365353732673607 could we always set |
we could - but a custom script can delegate to Changesets and that can create this file. If we’d pre-create it, it would be harder to distinguish between “there was no output” and “the script is output-unaware” |
| vi.mock("@actions/core", async (importOriginal) => ({ | ||
| ...(await importOriginal<typeof import("@actions/core")>()), | ||
| warning: vi.fn(), | ||
| })); |
There was a problem hiding this comment.
we could do this instead, which is cleaner imo
vi.mock("@actions/core", { spy: true })
const mockedWarning = vi.mocked(core.warning)3 participants
No description provided.