Repository navigation
fix(nicojk): 録画オフセットによっては取得が始まらないのを修正 - #38
Merged
Merged
Conversation
レビュアー向けガイドタイミングが初期状態では利用できない、または区間が変更される録画について、ソース解決にタイミングを組み込むとともに、KakologManager に保留／再試行状態を保持し、遅延、空、追加、変更、早すぎるソースに対する回帰テストを追加することで、録画コメントの取得を修正します。 タイミング解決後に録画コメントの取得を再試行するシーケンス図sequenceDiagram
participant App
participant KakologManager
participant CommentAPI
App->>App: getCommentSourceResolutionKey(playable, isRecorded, jkId)
App->>KakologManager: setSources(replaySources)
KakologManager->>KakologManager: hasPendingInitialSourceFetch()
KakologManager->>CommentAPI: fetchMiyouSourceChunk(sourceStart, sourceEnd)
alt source interval is not yet queryable
CommentAPI-->>KakologManager: empty result
KakologManager->>KakologManager: retain needsInitialFetch
else source interval is queryable
CommentAPI-->>KakologManager: comments
KakologManager-->>App: recordedCommentsReady
end
App->>KakologManager: setSources(updated timing)
KakologManager->>CommentAPI: retry pending source fetch
録画コメントソース解決のフロー図flowchart TD
A[Timing or source data changes] --> B[getCommentSourceResolutionKey]
B --> C{Valid startAt, duration, and source interval?}
C -- No --> D[Wait for updated timing]
D --> A
C -- Yes --> E[setSources]
E --> F{Pending initial fetch?}
F -- Yes --> G[Fetch source chunks]
G --> H{Queryable interval exists?}
H -- No --> I[Keep needsInitialFetch for retry]
I --> A
H -- Yes --> J[Store comments and update completion]
F -- No --> J
ファイル単位の変更
ヒントとコマンドSourcery とのやり取り
利用環境のカスタマイズダッシュボードにアクセスして、次の操作を行えます。
ヘルプを得る
Original review guide in EnglishReviewer's GuideFixes recorded comment acquisition for recordings whose timing is initially unavailable or whose interval changes, by incorporating timing into source resolution, retaining pending/retry state in KakologManager, and adding regression coverage for delayed, empty, appended, changed, and too-recent sources. Sequence diagram for retrying recorded comment acquisition after timing resolutionsequenceDiagram
participant App
participant KakologManager
participant CommentAPI
App->>App: getCommentSourceResolutionKey(playable, isRecorded, jkId)
App->>KakologManager: setSources(replaySources)
KakologManager->>KakologManager: hasPendingInitialSourceFetch()
KakologManager->>CommentAPI: fetchMiyouSourceChunk(sourceStart, sourceEnd)
alt source interval is not yet queryable
CommentAPI-->>KakologManager: empty result
KakologManager->>KakologManager: retain needsInitialFetch
else source interval is queryable
CommentAPI-->>KakologManager: comments
KakologManager-->>App: recordedCommentsReady
end
App->>KakologManager: setSources(updated timing)
KakologManager->>CommentAPI: retry pending source fetch
Flow diagram for recorded comment source resolutionflowchart TD
A[Timing or source data changes] --> B[getCommentSourceResolutionKey]
B --> C{Valid startAt, duration, and source interval?}
C -- No --> D[Wait for updated timing]
D --> A
C -- Yes --> E[setSources]
E --> F{Pending initial fetch?}
F -- Yes --> G[Fetch source chunks]
G --> H{Queryable interval exists?}
H -- No --> I[Keep needsInitialFetch for retry]
I --> A
H -- Yes --> J[Store comments and update completion]
F -- No --> J
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sourceryによる概要
ソースのタイミングが変更された場合や、インターバルが一時的に利用できない場合に、取得処理の開始が妨げられるのではなく、録音済みコメントの取得を再試行するよう修正しました。
新機能:
バグ修正:
機能強化:
テスト:
Original summary in English
Summary by Sourcery
Fix recorded comment retrieval so source timing changes and temporarily unavailable intervals are retried instead of preventing acquisition from starting.
New Features:
Bug Fixes:
Enhancements:
Tests: