Skip to content

Adds gh actions pipeline for build & test - #136

Open
Gürkan İndibay (gurkanindibay) wants to merge 9 commits into
masterfrom
hll-gha
Open

Adds gh actions pipeline for build & test#136
Gürkan İndibay (gurkanindibay) wants to merge 9 commits into
masterfrom
hll-gha

Conversation

@gurkanindibay

@gurkanindibay Gürkan İndibay (gurkanindibay) commented Aug 26, 2022

Copy link
Copy Markdown

TODO: After merging citusdata/tools#239 tools version should be updated with tag to be created

@hanefi

Copy link
Copy Markdown
Contributor

Gürkan İndibay (@gurkanindibay) please request reviews after the tests pass and the implementation is complete.

Comment thread .github/workflows/build-package.yml Outdated
Comment on lines +20 to +22
- 9.4
- 9.5
- 9.6

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These PG versions are not supported anymore. We can drop them.

@gurkanindibay

Copy link
Copy Markdown
Author

Gürkan İndibay (@gurkanindibay) please request reviews after the tests pass and the implementation is complete.

Hanefi Onaldi (@hanefi) there are compile and test errors. I've sent it to check and fix it. My main task is to add the pipeline not to fix the tests. If there are some parameters to add please notify me and I can add this param. But I think failures are not related to pipeline

Comment thread .github/workflows/build-package.yml Outdated
@hanefi

Copy link
Copy Markdown
Contributor

I fixed one missing test change we missed when bumping 2.17, and removed the PostgreSQL versions that EOLd.

All that is missing is a development on tools repository for PG15 support. I have an open PR citusdata/tools#239 . Can we use that here? That PR is not tested enough, and some more work may be needed. I guess that is part of creating the pipeline. Can you take over that PR Gürkan İndibay (@gurkanindibay) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants