Only run failed jobs on internal test re-runs - #5657
Merged
joshua-spacetime merged 9 commits intoAug 7, 2026
Conversation
joshua-spacetime
marked this pull request as ready for review
August 4, 2026 03:50
joshua-spacetime
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
August 4, 2026 03:50
joshua-spacetime
force-pushed
the
joshua/ci/internal-tests-re-run-from-failed
branch
3 times, most recently
from
August 4, 2026 21:47
f245d7d to
c5aacc0
Compare
jdetter
reviewed
Aug 5, 2026
jdetter
reviewed
Aug 5, 2026
joshua-spacetime
force-pushed
the
joshua/ci/internal-tests-re-run-from-failed
branch
from
August 5, 2026 23:28
c5aacc0 to
067b200
Compare
bfops
reviewed
Aug 5, 2026
bfops
reviewed
Aug 6, 2026
bfops
reviewed
Aug 6, 2026
bfops
reviewed
Aug 6, 2026
bfops
reviewed
Aug 6, 2026
bfops
reviewed
Aug 6, 2026
joshua-spacetime
force-pushed
the
joshua/ci/internal-tests-re-run-from-failed
branch
2 times, most recently
from
August 6, 2026 19:36
699feb1 to
73889cd
Compare
Collaborator
Author
|
@bfops I've decided to rescope these changes to just the original proposed feature. As a result, I've removed the |
bfops
reviewed
Aug 6, 2026
joshua-spacetime
force-pushed
the
joshua/ci/internal-tests-re-run-from-failed
branch
from
August 7, 2026 01:57
a1b5d64 to
6094e5f
Compare
joshua-spacetime
force-pushed
the
joshua/ci/internal-tests-re-run-from-failed
branch
from
August 7, 2026 19:22
e86e9d7 to
5747680
Compare
bfops
reviewed
Aug 7, 2026
bfops
reviewed
Aug 7, 2026
bfops
reviewed
Aug 7, 2026
bfops
reviewed
Aug 7, 2026
bfops
reviewed
Aug 7, 2026
bfops
reviewed
Aug 7, 2026
bfops
reviewed
Aug 7, 2026
bfops
reviewed
Aug 7, 2026
bfops
approved these changes
Aug 7, 2026
bfops
left a comment
Collaborator
There was a problem hiding this comment.
a bunch of nits and one small change. otherwise, LGTM
joshua-spacetime
deleted the
joshua/ci/internal-tests-re-run-from-failed
branch
August 7, 2026 22:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Internal tests no longer dispatch a new private workflow if there's a linked private PR. Instead they report the results of the linked private workflow. If there is no linked private PR, it will dispatch a new private workflow. However if any of the jobs within that workflow fail, re-running the internal test will only run those failed jobs, assuming the refs haven't changed.
The purpose of this is to cut down on the number of redundant CI jobs/workflows and to make private test flakes much less costly for public changes.
API and ABI breaking changes
N/A
Expected complexity level and risk
3
Testing