Skip to content

Only run failed jobs on internal test re-runs - #5657

Merged
joshua-spacetime merged 9 commits into
masterfrom
joshua/ci/internal-tests-re-run-from-failed
Aug 7, 2026
Merged

Only run failed jobs on internal test re-runs#5657
joshua-spacetime merged 9 commits into
masterfrom
joshua/ci/internal-tests-re-run-from-failed

Conversation

@joshua-spacetime

@joshua-spacetime joshua-spacetime commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Description of Changes

Internal tests no longer dispatch a new private workflow if there's a linked private PR. Instead they report the results of the linked private workflow. If there is no linked private PR, it will dispatch a new private workflow. However if any of the jobs within that workflow fail, re-running the internal test will only run those failed jobs, assuming the refs haven't changed.

The purpose of this is to cut down on the number of redundant CI jobs/workflows and to make private test flakes much less costly for public changes.

API and ABI breaking changes

N/A

Expected complexity level and risk

3

Testing

  • Linked private PR with private CI in progress: Internal tests wait on private CI to finish and report its result
  • Linked private PR with private CI failure: Internal tests will re-run only the failed jobs
  • Linked private PR with private CI success: Internal tests will not re-run CI, they will report the successful result
  • Linked private PR but public SHA doesn't match: Error message (please update submodule)
  • Public only change with no matching workflow: Dispatch new internal tests workflow
  • Public only change with matching workflow: Report success or re-run failed jobs only

@joshua-spacetime
joshua-spacetime marked this pull request as ready for review August 4, 2026 03:50
@joshua-spacetime
joshua-spacetime force-pushed the joshua/ci/internal-tests-re-run-from-failed branch 3 times, most recently from f245d7d to c5aacc0 Compare August 4, 2026 21:47
Comment thread tools/github-api/src/lib.rs Outdated

@jdetter jdetter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking from me on this, we'll sync about it during standup with @bfops

Comment thread tools/ci/src/internal_tests.rs Outdated
Comment thread tools/ci/src/internal_tests.rs Outdated
@joshua-spacetime
joshua-spacetime force-pushed the joshua/ci/internal-tests-re-run-from-failed branch from c5aacc0 to 067b200 Compare August 5, 2026 23:28
Comment thread tools/github-api/src/related_prs.rs Outdated
Comment thread .github/actions/internal-tests-coordinate/action.yml Outdated
Comment thread .github/workflows/internal-tests.yml Outdated
Comment thread tools/ci/src/internal_tests.rs Outdated
Comment thread tools/ci/src/internal_tests.rs Outdated
Comment thread tools/ci/src/internal_tests.rs Outdated
@joshua-spacetime
joshua-spacetime force-pushed the joshua/ci/internal-tests-re-run-from-failed branch 2 times, most recently from 699feb1 to 73889cd Compare August 6, 2026 19:36
@joshua-spacetime

Copy link
Copy Markdown
Collaborator Author

@bfops I've decided to rescope these changes to just the original proposed feature. As a result, I've removed the GithubApi wrapper entirely.

@joshua-spacetime
joshua-spacetime requested a review from bfops August 6, 2026 19:52
Comment thread tools/ci/src/main.rs Outdated
@joshua-spacetime
joshua-spacetime force-pushed the joshua/ci/internal-tests-re-run-from-failed branch from a1b5d64 to 6094e5f Compare August 7, 2026 01:57
@joshua-spacetime
joshua-spacetime force-pushed the joshua/ci/internal-tests-re-run-from-failed branch from e86e9d7 to 5747680 Compare August 7, 2026 19:22
Comment thread tools/ci/src/internal_tests.rs Outdated
Comment thread tools/ci/src/internal_tests.rs
Comment thread tools/ci/src/internal_tests.rs Outdated
Comment thread tools/ci/src/internal_tests.rs Outdated
Comment thread tools/ci/src/internal_tests.rs Outdated
Comment thread tools/ci/src/internal_tests.rs Outdated
Comment thread tools/ci/src/internal_tests.rs Outdated
Comment thread tools/ci/src/internal_tests.rs Outdated

@bfops bfops left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bunch of nits and one small change. otherwise, LGTM

@joshua-spacetime
joshua-spacetime added this pull request to the merge queue Aug 7, 2026
Merged via the queue into master with commit 27a3841 Aug 7, 2026
47 of 49 checks passed
@joshua-spacetime
joshua-spacetime deleted the joshua/ci/internal-tests-re-run-from-failed branch August 7, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants