Repository navigation
feat: name the background flag --daemon and add the leader help overlay - #65
Merged
Merged
Conversation
Detaching is what the TUI does with `<prefix> q`; the flag that shared the name starts the session as a background daemon, so `-d attach` read as two opposite requests.
`--exec`, `--port`, `--bind` and `--daemon` only shape a session that is about to start, so pairing them with `status`, `stop`, `init`, `plugin` or `update` was a silent no-op. `attach` keeps accepting them: it hands them to the daemon it starts.
`<prefix> ?` — or `<prefix> h` — raises every command with its keys on one screen, matching the web viewer's shortcut sheet. Workspace-level like the repo dialog, so it opens with no project on screen, where it is needed most.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
-dis now--daemoninstead of--detach. Detaching is what<prefix> qdoes to the TUI, so-d attachread as two opposite requests. The short flag is unchanged;child_argsnow strips the new spelling when re-execing the background copy.--exec,--port,--bindand--daemonare rejected oninit,plugin,stop,statusandupdate, which start no session and silently dropped them.attachstill accepts them and hands them to the daemon it starts.<prefix> ?, or<prefix> h, opens a help overlay listing every command with its keys, matching the web viewer's shortcut sheet. It is workspace-level, so it opens with no project on screen.j/k, the arrows,PageUp/PageDownandSpacescroll;Esc,Enter,q,?,handCtrl+Cclose. Every other key is consumed while it is up.Verification
cargo fmt --all --check,cargo build,cargo clippy --all-targets --all-features -- -D warningspass.cargo test: 1948 pass, withplatform::links::tests::immediate_editor_failure_is_reported_without_running_a_shellfailing under full-suite load and passing on its own. That test re-execs the test binary and expects it to exit insideEDITOR_STARTUP_GRACE; it fails the same way ondevwithout these changes, so it is a pre-existing timing flake rather than a regression here.The viewer bundle is untouched.