Conversation
30 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SbPListstate when buffer growth allocation failsINT_MAXregression coverageProblem
SbPList::grow()currently updatesitembuffersizebefore allocating the replacement buffer. Ifnew[]throws, the old buffer remains installed while the list records the larger capacity. A later append then sees apparent spare capacity, skips growth, and writes past the actual buffer.The same growth path can be reached through append, insert, expanding subscript, and copy/assignment into an existing smaller list.
Fix
Compute the target capacity locally, allocate and copy first, and publish the new buffer and capacity only after all potentially throwing work has succeeded. Since the stored elements are
void *, copying them cannot throw, so allocation failure now provides the strong exception guarantee.The change also guards doubling beyond
INT_MAX / 2and theINT_MAX + 1calculation used by expanding subscript. The negative-size guard inexpandlist()also protects callers compiled with the previous inlineoperator[]implementation.There is no public API or object-layout change, and successful growth keeps the existing capacity policy.
Tests
std::bad_allocand unchanged list state