Skip to content

Fix SoPath assignment auditor lifecycle - #748

Merged
veelo merged 10 commits into
coin3d:masterfrom
Dikluwe:fix/sopath-assignment-auditor-lifecycle
Oct 1, 2026
Merged

veelo merged 10 commits into
coin3d:masterfrom
Dikluwe:fix/sopath-assignment-auditor-lifecycle

Conversation

@Dikluwe

@Dikluwe Dikluwe commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • keep the destination path and its existing child-list auditors intact while reserving capacity and registering the new route
  • roll back partially registered auditors if an allocation fails
  • remove the old auditors before replacing the route, while preserving self-assignment and copy construction
  • merge the current master after Validate SoPath auditor callbacks in all builds #749 and retain both test-registration blocks

Tests

  • regression cases cover reassignment, self-assignment, copy construction, allocation failures during list growth and auditor registration, shared roots, shorter and empty paths, and transitions from SoTempPath
  • the combined Fix SoPath assignment auditor lifecycle #748 + Validate SoPath auditor callbacks in all builds #749 Release suite passes: 31/31 CTests
  • the nine focused assignment and callback tests pass with AddressSanitizer and UndefinedBehaviorSanitizer
  • ABI compatibility, CodeQL, Ubuntu, Windows, and macOS checks pass on the current PR head

Compatibility

No public API or object-layout change.

@Dikluwe
Dikluwe marked this pull request as ready for review October 1, 2026 12:47
@veelo
veelo merged commit d682aa3 into coin3d:master Oct 1, 2026
9 checks passed
@veelo

veelo commented Oct 1, 2026

Copy link
Copy Markdown
Member

Thanks.

@Dikluwe
Dikluwe deleted the fix/sopath-assignment-auditor-lifecycle branch October 4, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants