fix: validate Bazaar schema formats - #283
Open
epistemedeus wants to merge 1 commit into
Open
Conversation
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
validateDiscoveryExtension()compiled Bazaar schemas without standard JSONSchema format handlers. AJV therefore ignored declarations such as
format: "uri"andformat: "date-time", accepted invalid values, and printedwarnings while validating otherwise machine-readable discovery data.
This patch registers
ajv-formatson the existing AJV instance and adds invalidand valid URI/date-time cases. It does not change the Bazaar schema shape or
payment behavior.
Most of this patch was generated with Codex. I reviewed the source and final
diff, reproduced the defect with the published package, removed unrelated
lockfile changes, and ran the checks below.
Tests
pnpm --filter @x402/core buildpnpm --filter @x402/extensions test(386 passed)pnpm --filter @x402/extensions lint:checkpnpm --filter @x402/extensions format:checkpnpm --filter @x402/extensions buildChecklist