Skip to content

Minor fixes: restart php-fpm during sigpipe, Install jq for forge commands - #213

Merged
MickLesk merged 5 commits into
mainfrom
fix/install-test-findings
Nov 7, 2026
Merged

MickLesk merged 5 commits into
mainfrom
fix/install-test-findings

Conversation

@MickLesk

@MickLesk MickLesk commented Nov 6, 2026

Copy link
Copy Markdown
Member

✍️ Description

  • Install jq before every GitHub call Forge If Missing
  • restart php-fpm If an sigpipe is present during unit Check
  • name Missing command/Tool inside a call / pipe

🔗 Related Issue

Fixes #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected (Proxmox VE and/or Incus, as applicable).
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.
  • API.txt regenerated – If a function signature or behavior changed, API.txt was updated to match.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing behavior in a way that may require updates in every downstream script.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, docs/, CONTRIBUTING.md, or other docs.

🤖 AI Assistance (X in brackets)

If you used an AI tool (GitHub Copilot, Claude, ChatGPT, etc.) to write or generate any code in this PR, you must confirm compliance below.
Select exactly one option.

  • No AI used – Code was written without AI assistance.
  • AI was used – The output has been reviewed and corrected, and I take responsibility for it matching this repo's conventions.

get_latest_gh_tag read "no tags" without jq, so databasement built a mongo-tools URL without a version.
list-unit-files | grep -q returned 141 under pipefail, so setup_php skipped the restart and typecho found no socket.
Exit 127 on RELEASE=$(curl -fsSL ... | jq ...) blamed -fsSL instead of jq.
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Try this branch

The engine and the scripts resolve independently, so a production script can
be run against the engine from this PR by setting one variable:

COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/install-test-findings \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"

Swap ct/debian.sh for whatever exercises the change.

Run a script from a fork as well
curl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/install-test-findings/tools/run.sh |
  bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
             https://raw.githubusercontent.com/community-scripts/core/fix/install-test-findings

Note that run.sh is reached through a pipe, so the script it starts inherits
an exhausted stdin. Whiptail is fine — it opens /dev/tty — but a plain read
would see EOF. The single-variable form above does not have that problem.

Useful flags while testing

dev_mode=net logs every engine fetch with status and duration, which is the
quickest way to confirm the branch is really being used. dev_mode=keep stops a
failed build from deleting the container along with the evidence.

@MickLesk
MickLesk marked this pull request as draft November 6, 2026 13:17
A Node crash prints the minified source line of the throw site. In
jumpserver's yarn failure that line filled the 10 KB budget, and
head -c dropped the actual error. Lines are cut at 1000 characters
and the budget now keeps the end.
@MickLesk MickLesk changed the title Minor fixes: restart php-fpm Düring sigpipe, Install jq for forge commands Minor fixes: restart php-fpm during sigpipe, Install jq for forge commands Nov 6, 2026
@MickLesk
MickLesk marked this pull request as ready for review November 6, 2026 16:12
@MickLesk
MickLesk merged commit acdf0ff into main Nov 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant