[3.10] build: enable aarch64 optimizations - #904
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/33723408923. Examine the logs at this URL for more detail. |
d159d17 to
028799a
Compare
|
@msarahan @xhochy @scopatz @pelson @ocefpaf @jakirkham @isuruf @mbargull @katietz Could you please review this PR when possible? It is now rebased onto the latest 3.10 branch and the merge conflict has been resolved. The diff remains limited to removing the three-line Linux AArch64 optimization guard and bumping the build number. Thank you! |
|
@msarahan @xhochy @scopatz @pelson @ocefpaf @jakirkham @isuruf @mbargull @katietz The corresponding Python 3.11 PR (#905) and Python 3.12 PR (#906) have now both been merged. Could you please review and merge this Python 3.10 counterpart as well? It is currently mergeable and contains the same scoped Linux AArch64 optimization change. Thank you! |
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was not passing and not merged. |
PPC64LE cross builds otherwise resolve Tk 9, while CPython 3.10 still expects Tcl/Tk 8.6 headers and libraries.
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly conda-forge automerge bot! Commits were made to this PR after the |
…026.09.02.08.53.4
7cc8f93 to
8fac5bf
Compare
|
@isuruf @xhochy The previous PPC64LE failure was caused by the unpinned host dependency resolving Tk 9.0.4, while CPython 3.10 still expects Tcl/Tk 8.6 headers and libraries. Commit 8158a03 pins the host requirement to |
8158a03 to
7cc8f93
Compare
|
For clarity on why this Python 3.10 PR now has a larger diff than the already merged #905 and #906: The intended AArch64 optimization change is still the same: remove the three-line The additional changes are specific to rebuilding the older 3.10 recipe against the current dependency set:
Consequently, the comparison contains 21 files, but only three recipe inputs represent intentional changes: The current head now passes Linux AArch64, Linux x86_64, Linux PPC64LE, Windows, and both macOS jobs. Could you review this rerendered state and restore the The separate suggestion to enable optimizations for cross-compiled PPC64LE has not been applied here. |
Summary
Linux AArch64 builds now run natively, but the Python 3.10 branch still
inherits the historical emulated-CI override that disables its existing
LTO and PGO path.
Changes
meta.yaml host requirement unpinned
Windows and PPC64LE CI configurations
The rerender also refreshes generated CI templates and current compiler
pins; those files were generated by conda-forge-admin rather than edited
manually.
Test Plan
profile-opt, and PROFILE_TASK="-m test --pgo"
linux-ppc64le
previous direct host pin did not set the tk variant value consumed by
run_test.py
.ci_support/linux_ppc64le_.yaml both contain tk: 8.6
Known Concern
Native AArch64 Python rebuilds have an open downstream cross-build
compatibility issue in #880. This PR does not alter that sysconfig/linker
behavior.
Part of #903