Skip to content

[3.12] Fix flto cflag replacement - #921

Merged
isuruf merged 2 commits into
conda-forge:3.12from
h-vetinari:3.12
Sep 2, 2026
Merged

[3.12] Fix flto cflag replacement#921
isuruf merged 2 commits into
conda-forge:3.12from
h-vetinari:3.12

Conversation

@h-vetinari

@h-vetinari h-vetinari commented Sep 2, 2026

Copy link
Copy Markdown
Member

Backport of #919

@ClayWarren

Copy link
Copy Markdown

PR #913 accidentally made the debug-Python weak run export unconditional. I checked the release artifact win-64/python-3.12.14-hb12b558_2_cpython.conda; its info/run_exports.json contains:

{"noarch": ["python"], "weak": ["python_abi 3.12.* *_cp312", "python 3.12.* *_debug_cpython"]}

That is now breaking the normal win-64 Python 3.12 test solve in pywin32-ctypes #20. Before #913, the python ... *_debug_cpython export was guarded by {% if py_interp_debug == "yes" %}.

Since this PR already bumps 3.12 to build 3, can that guard be restored here so the corrected artifacts replace build 2 without another Python rebuild?

@conda-forge-admin

conda-forge-admin commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/33684878559. Examine the logs at this URL for more detail.

@jeongseok-meta

Copy link
Copy Markdown

Thanks for catching this. I confirmed the same issue in the normal Linux x86_64 and aarch64 Python 3.12.14 build-2 artifacts: both export python 3.12.* *_debug_cpython, while build 1 exports only python_abi 3.12.* *_cp312. That makes the Python 3.12 test environments in rerun-sdk #137 unsatisfiable after their packages build successfully. Restoring the py_interp_debug == "yes" guard in this build-3 PR should unblock them.

@h-vetinari

h-vetinari commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

Thanks for catching this, and apologies; this was a conflict resolution error while rebasing/cherry-picking. Could you send a PR to https://github.com/conda-forge/admin-requests to mark the (release variants of the) _2 / _102 builds as broken?

@ClayWarren

Copy link
Copy Markdown

Done: conda-forge/admin-requests#2319. It targets the six Python 3.12.14 build 2 release artifacts. The 3.12 branch has no build 102 release artifacts, so none were available to include.

@isuruf

isuruf commented Sep 2, 2026

Copy link
Copy Markdown
Member

Thanks

@isuruf
isuruf merged commit 9452475 into conda-forge:3.12 Sep 2, 2026
17 of 21 checks passed
@h-vetinari
h-vetinari deleted the 3.12 branch September 2, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants