[APIE-1106] Update kafka topic create/update to support JSON-valued Configs#3412
Draft
Yifei Yuan (yyuan097) wants to merge 10 commits into
Draft
[APIE-1106] Update kafka topic create/update to support JSON-valued Configs#3412Yifei Yuan (yyuan097) wants to merge 10 commits into
Yifei Yuan (yyuan097) wants to merge 10 commits into
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Release Notes
Breaking Changes
New Features
confluent kafka topic createcommand now supports reading configs from a property fileconfluent kafka topic [create | update]commands now support reading json-valued configs from a config file with --config flag, or from inline configsBug Fixes
Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Allowed two new configs
confluent.key.associationandconfluent.value.associationin Confluent Cloud'sconfluent kafka topic (create | update) <topic>command.This PR adds file support for
kafka topic createand inline JSON support for bothkafka topic (create | update).pcmd.AddTopicConfigFlagregisters the topic config asStringArrayinstead ofStringSlice, so pflag no longer CSV-parses the vales -> this preserves JSON value.properties.GetMapFromArraysplits the configs by comma, it validates JSON value forconfluent.(key|value).associationkeys, all other keys keeps the existing behaviourBlast Radius
Confluent Cloud customers using
confluent kafka topic (create | update)with any--configcould be impacted if the new parser misparses inputAll other
--configconsumers will not be impacted (stillStringSliceand old parser), this change is designed to be backward compatible.References
This PR extends from #3394
JIRA APIE-1106
INIT-11067 Odyssey Explicit Topic Subject Association - CLI
Test & Review
Manual Verifications & Tests:
APIE-1106 Support JSON-valued Configs from Config File - CLI Testing
WIP: Support Inline JSON-valued configs