Skip to content

Ad Block detection is broken in chrome #141

Open

Description

@adamgamble

Here is an example: http://s3.amazonaws.com/dfp-test-block/index.html?google_console=1&networkID=15572793&adunitID=Leader&dimensions=728x90

Within the last week or so something has changed (I assume in DFP somewhere) and its triggering the adblock code in jquery dfp even if no adblocker is installed. The "afterAdBlocked" callback fires even if the ad loads. It appears to possibly be a race condition? This only seems to be happening in chrome. I used browserstack to try several different older versions of chrome and it happens in everyone one I tried, so I don't think its a chrome version thing.

Activity

  1. changed the title [-]Ad Block detection is broken.[/-] [+]Ad Block detection is broken in chrome[/+] on Dec 14, 2016
  2. BowlingX commented on Feb 20, 2017

    @BowlingX
    Contributor

    I found the issue, will provide a pull request

  3. added a commit that references this issue on Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions