Repository navigation
Responsive/sizeMapping returning wrong sizes #150
Description
Hello & thanks for an awesome script.
I am trying to set up a responsive pushdown panorama banner using 4 different sizes (3 breakpoints).
Banner load fine but the actual size mapping seems to be lost, all banners seem to load random no matter window size :/
Pen: https://codepen.io/martink/full/zjLrbx/
I don't know what i am doing wrong here, according to all posts i find about this its the correct markup (or i have missed something vital?)
Best regards
Martin
Activity
ozeone commentedon May 14, 2018
The line items
omelsoft commentedon May 18, 2018
In your ad tag, you should specify the data-size-mapping attribute not data-dimensions. With data-dimensions, it will randomly pick a creative size depending on your line items settings.
ozeone commentedon May 21, 2018
@omelsoft I have updated the pen and banners load, but its still the same result (mobile showing random no matter browser size), can you see what i am doing wrong?
I ma using both data-dimensions and data-size-mapping with the same values, is this the way to do it?
Feel free to update/fork pen ;) And thanks for helpinig
ozeone commentedon May 22, 2018
just got this to work i think, misunderstood the use data-size-mapping from start :/
I changed data-size-mapping to be the name of the size mapping (makes sense) and everything started working :)
Final working pen: https://codepen.io/martink/pen/zjLrbx