Restore Room message actions on the direct page - #80
Merged
NWYLZW merged 1 commit intoSep 8, 2026
Merged
Conversation
NWYLZW
force-pushed
the
codex/chatroom-74-message-actions
branch
from
September 8, 2026 13:10
37fc6bc to
06150e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The direct Room page previously ignored ordinary message
actions, while the retained Host Shell rendered the first two actions inline and placed the remainder in an overflow menu. This branch restores that behavior on the plugin-owned page without reintroducing a Shell source.The UI shows two direct actions, preserves action order, displays remaining actions in the existing keyboard-accessible menu, exposes disabled reasons, fences duplicate clicks while a command is pending, reports failures and permits a later retry. Execution re-resolves the action by Room, message and action ID from the current projection before calling the owner-bound public
ctx.commands.executeservice. Removed, disabled, stale or disposed actions fail before command dispatch; invocation keys are encoded tuples so special characters cannot alias another action.Current Chatroom production projections emit empty ordinary-message action arrays, so the behavioral tests inject protocol-valid actions to exercise this compatibility path. The change does not add a fabricated product action or a second persistence ledger.
This is an isolated review delta on top of the #73/#74 ownership candidate in PR #78. Native product acceptance and old Host Shell retirement remain separate gates.
Validation
npm run check— 373/373 tests pass, including CSS lint, typecheck and production buildnpm run format:checknpm run lint:source