Repository navigation
feat(client): use selected Game Room brand icon - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Game Room now exposes the selected 256px brand icon through the public
CordisXPluginModule.iconmetadata used by the Host plugin list. The trackedclient/assets/icon.pngis byte-identical to the approved asset (SHA256f2338dcd6454aef16666a8a7d45fcf66704e378999ad15f96d92bd3307f26f51); generated typed metadata embeds those bytes without a network dependency. Menu/action icons, permissions, behavior and versions are unchanged.The package includes the PNG, and artifact validation checks both embedded bytes and the complete runtime package allowlist. The client README now describes the actual SDK digest-verification script and pinned Host source, replacing stale preparation instructions. This private client remains source-distributed; no npm release or new publishing system is introduced.
Validation: selected PNG bytes and 256×256 dimensions; actual pinned Host
pluginBrandIconDataUrlprojection; SDK archive digests;git diff --check. Existing CI runs the full client check, development dry-run, production artifact/package checks and cross-service integration. Native UI acceptance is not claimed.Base:
1b1e9692b3114d6db905d83f00fd159f6041324a.