Repository navigation
Simplify TileArray replacement and model typed buffers - #8
Merged
Merged
Conversation
guosran
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces an explicit type/value model for TileArray buffers and makes pattern-specific code responsible for replacement legality.
It adds:
SynapseTypeandSynapseValuebase classes;BufferTypefor shape and element type;Bufferfor symbolic program arguments;BufferSlicefor typed static selections such asA[:, k];It also simplifies
PatternReplacer: patterns now define their own applicability and semantic preconditions, while the shared replacement path adapts buffer types, stages the generated kernel, and verifies the resulting IR.Example
The slice remains a frontend value. It lowers directly to the original buffer operand and configured element offsets: