Skip to content

fix: Tags missing in nodegroups added using cortex cluster configure comman... - #2466

Open
Roshan931 wants to merge 1 commit into
cortexlabs:masterfrom
Roshan931:prilog/fix-error-metadata-tags-omitted-from-eksctl-config-08-21-2026-4a3478
Open

fix: Tags missing in nodegroups added using cortex cluster configure comman...#2466
Roshan931 wants to merge 1 commit into
cortexlabs:masterfrom
Roshan931:prilog/fix-error-metadata-tags-omitted-from-eksctl-config-08-21-2026-4a3478

Conversation

@Roshan931

Copy link
Copy Markdown

Fixes #2392

Root cause

metadata.tags omitted from eksctl config on the add-nodegroup path

Changes

  • Set eksctl metadata.tags from cluster_config["tags"] on the base ClusterConfig dict in manager/generate_eks.py, so the --add-cortex-node-groups output used by eksctl create nodegroup -f carries the cluster tags, matching the cortex cluster up path.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tags missing in nodegroups added using cortex cluster configure command

2 participants