Skip to content

fix(webhook): restore aiohttp request in legacy webhook func_args#862

Open
diegograssato wants to merge 2 commits into
custom-components:masterfrom
diegograssato:master
Open

fix(webhook): restore aiohttp request in legacy webhook func_args#862
diegograssato wants to merge 2 commits into
custom-components:masterfrom
diegograssato:master

Conversation

@diegograssato

Copy link
Copy Markdown

Restores request in the kwargs payload built by the legacy webhook handler.

Why:

User webhook functions may need direct access to aiohttp request
(headers, method, query and raw body).
This is required for HMAC/signature validation and advanced webhook checks.
Aligns behavior with decorators/webhook.py (commit 5612dd4), which already
exposes request to webhook trigger functions.
Compatibility:

Backward compatible for scripts that do not declare request.
Comandos prontos para commit:

cd /home/grassato/workspace/pyscript
git add custom_components/pyscript/webhook.py
git commit -m "fix(webhook): restore aiohttp request in legacy webhook func_args" -m "Restores request in the kwargs payload built by the legacy webhook handler.
Why:

User webhook functions may need direct access to aiohttp request (headers, method, query and raw body).
This is required for HMAC/signature validation and advanced webhook checks.
Aligns behavior with decorators/webhook.py (commit 5612dd4), which already exposes request to webhook trigger functions.
Compatibility:

Backward compatible for scripts that do not declare request."

@craigbarratt

Copy link
Copy Markdown
Member

Thanks for the PR. Can you fix the indicated errors?

The test you added actually tests the new decorator code, not the legacy mode. I'm actually fine with that since everyone should be using the new decorator code, which already supports the request func arg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants