Repository navigation
fix(slack): return to the integrations settings page after adding a workspace - #6887
Merged
Merged
Conversation
…orkspace
The settings page passed /account/integrations as the Slack OAuth return
path. Since settings moved, next.config redirects /account/:path* to
/settings/:path*, which lands on /settings/integrations, a route that
does not exist (the page lives at /settings/customization/integrations),
so connecting a workspace from settings ended on a 404.
Pass the page's own pathname instead, and redirect /account/integrations
to the real page for old links and OAuth flows in flight at deploy time.
The new squad modal passed ${webappUrl}squads/new, which is an absolute
URL on the extension. The API only accepts plain paths and fell back to
/, so extension users landed on the home page instead of squad creation.
It now passes the plain path.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
"Add workspace" from Settings > Integrations ended on a 404. The page passed
/account/integrationsas the Slack OAuth return path;next.configredirects/account/:path*to/settings/:path*, which gives/settings/integrations, a route that doesn't exist. The page lives at/settings/customization/integrationssince the settings revamp.router.pathname, which can't go stale on a future move and is always a plain path (the only form the API accepts).next.config.ts:/account/integrationsredirects to/settings/customization/integrations, before the generic/account/:path*rule, for old links and OAuth flows in flight at deploy time.NewSquadModalpassed${webappUrl}squads/new?fs=true, which is an absolute URL on the extension. The API rejects it and falls back to/, so extension users landed on the home page instead of squad creation. It now passes/squads/new?fs=true.Events
No new tracking events.
Experiment
No new experiments.
Preview domain
https://fix-slack-add-workspace-redirect.preview.app.daily.dev