Repository navigation
fix: refresh CV upload banner image and responsive layout - #6964
Merged
Merged
Conversation
Swap the three per-breakpoint covers for a single new illustration, rebuild the layout so the image sits on top on phones and on the right from tablet up, and drop the banner's own max width so it always matches the feed cards. Adds a Storybook story that shows the banner above a snapshot of the production feed at six resolutions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Replace the single 1944px banner image with 640/1024/1536px webp variants and a srcset, so phones no longer download the desktop asset - Shift the tablet crop to keep the developer and dog in frame and shorten the left fade so it no longer covers the developer - Mark the illustration as decorative (empty alt) - Reuse the existing feed mocks in the story instead of a production feed snapshot
main removed stories/features/feed, so the story's import of feedHero.mocks broke the Storybook build.
tomeredlich
force-pushed
the
fix/cv-upload-banner-image
branch
from
October 20, 2026 13:29
2d348a9 to
8d67fc7
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
/app/assets, instead of three per-breakpoint covers.max-w-[63.75rem], so it always matches the feed cards' width.cover/imageprops and theuploadCvBgLaptop/uploadCvBgTabletconstants.Storybook
Features/Profile/ProfileUploadBanner→ "In the feed · all resolutions" shows the banner above a snapshot of the production feed at 320 to 1920px.🤖 Generated with Claude Code
Preview domain
https://fix-cv-upload-banner-image.preview.app.daily.dev