Repository navigation
fix(quests): show Plus-locked quests in the v2 sidebar quest list - #6968
Merged
Merged
Conversation
Member
Author
|
Before / after. The two Plus-quest rows are from the Sidebar row story, for a non-Plus user. Before: a completed Plus quest shows 3/3 with a check and no way to claim. After: it shows Claim with Plus, and in-progress Plus quests show a lock.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tsahimatsliah
force-pushed
the
fix/sidebar-locked-plus-quests
branch
from
October 20, 2026 12:07
68261dc to
71cdf30
Compare
tsahimatsliah
force-pushed
the
fix/sidebar-locked-plus-quests
branch
from
October 20, 2026 12:20
71cdf30 to
cd7ef0f
Compare
tsahimatsliah
force-pushed
the
fix/sidebar-locked-plus-quests
branch
from
October 20, 2026 12:43
cd7ef0f to
fcd6e17
Compare
tsahimatsliah
force-pushed
the
fix/sidebar-locked-plus-quests
branch
from
October 20, 2026 13:10
fcd6e17 to
6199c18
Compare
The compact quest list in the v2 sidebar's Streak panel ignored the locked flag. A non-Plus user who completed a Plus-slot quest saw 3/3 with a check and no Claim button, which read as a broken claim (dailydotdev/daily#2160). Completed locked quests now show a 'Claim with Plus' button that links to /plus (logged as upgrade subscription, target 'quest sidebar'), and in-progress locked quests show a lock next to the step count. The rewards group can now shrink and wrap so the button fits the 288px rail hover panel with three rewards.
tsahimatsliah
force-pushed
the
fix/sidebar-locked-plus-quests
branch
from
October 20, 2026 13:26
6199c18 to
71ab68a
Compare
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes the "can't claim quests" report in dailydotdev/daily#2160.
The quest list in the v2 sidebar's Streak panel (
CompactQuestRow) ignoredlocked. When a non-Plus user finished a Plus-slot quest, the row showed3/3with a check and no Claim button, so it looked like claiming was broken. In production the reporter's three unclaimed completed quests are allplusOnly, and every regular quest they completed was claimed within seconds./plus, and the row link goes to Plus as well.Before / after screenshots (Storybook) are in the comment below.
Events
quest sidebarExperiment
No
🤖 Opened by Smith (AI assistant) on behalf of @tsahimatsliah.
Preview domain
https://fix-sidebar-locked-plus-quests.preview.app.daily.dev