Repository navigation
feat(ads): organic_ads kill switch for the post page's Kueez slots, off - #6970
Merged
Merged
Conversation
The post page's programmatic slots render their reserved white "Advertisements" card while the auction runs and collapse when no bid comes back. Kueez currently returns no bids (always on preview deployments, whose subdomain it has no demand for), so logged-out readers see the cards flash in and the article jump up 126px as the top leaderboard collapses. useOrganicAdSlots now sits behind an `organic_ads` GrowthBook kill switch, mirroring `read_ads` on the /read template. It defaults to off, so merging turns the slots off everywhere; creating the feature in GrowthBook with `true` brings them back without a deploy. With no slots, the page also skips the Prebid bundle and head hints.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Turns off the programmatic (Kueez) ad slots on the post page (
/posts/:id), behind a new GrowthBook kill switch,organic_ads.organic_adsin GrowthBook with valuetrue. No deploy needed.read_ads, the kill switch on the/readtemplate, which this PR leaves alone.Why
While its auction runs, each slot shows a reserved white "Advertisements" card, and it collapses when no bid comes back. Kueez is returning no bids:
So logged-out readers see the cards flash in for about 0.7s, then the article jumps up 126px when the top leaderboard collapses.
Tests
useOrganicAdSlotsreturns no slots while the switch is off (new spec inReadAdSlot.spec.tsx).PostPagead tests, run with the switch on, so they still cover the slots themselves.post/readspecs, webapp tests (642), full webapp tsc, and the strict typecheck on changed files all pass.Preview domain
https://claude-disable-organic-ads.preview.app.daily.dev