Skip to content

correct some intent and shared hungarian tests hungarian intent property translations - #615

Open
hammera wants to merge 31 commits into
daisy:hufrom
hammera:hu
Open

correct some intent and shared hungarian tests hungarian intent property translations#615
hammera wants to merge 31 commits into
daisy:hufrom
hammera:hu

Conversation

@hammera

@hammera hammera commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Hy Boys,

In #557 issue @MartheGjelstad intent attribute tests related answer, I doed some cosmetic changes with tests/language/hu/shared.rs file and tests/languages/hu/intent.rs files related.
Previous, the „perpendicular to” string, the „testing of” string parts (normal and prefix type test), and the „forced” string parts are presents untranslated, because I not known previous this string parts are need translate inside the MathML expression the intent attribute part into the affected tests, not with any Rules/Languages/hu awailable rule files. :-):-)
Have two test with me need restore after the main branch merge happened, because have differences the april 24 branch state of the hu branch and the actual branch state with two tests related.
So, now only have 523 hungarian tests again.

In my local machine following commands ran successfull:

  • cargo build,
  • cargo test Languages::hu,
  • cargo test --lib (navigation tests),
  • cargo check.

Cargo clippy me drops following output:

warning: casting to the same type is unnecessary (`u32` -> `u32`)
    --> src/speech.rs:2828:147
     |
2828 | ...32(*ch).unwrap(), *ch as u32);
     |                      ^^^^^^^^^^ help: try: `{ *ch }`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_cast
     = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: `mathcat` (lib) generated 1 warning (run `cargo clippy --fix --lib -p mathcat` to apply 1 suggestion)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.09s

Cargo test command drops me following result, I copyed only end of results:

failures:
    braille::Swedish::swedish::ex_6_15
    braille::Swedish::swedish::ex_6_16
    braille::Swedish::swedish::ex_6_19

test result: FAILED. 1422 passed; 3 failed; 31 ignored; 0 measured; 0 filtered out; finished in 6.22s

This result is equals the friday evening result, when the merge happened from the hu branch of the main branch.

Please merge this corrected tests into the github.com/daisy/mathcat repository hu branch, and after this merge, if this is possible please merge this change to the github.com/daisy/mathcat repo main branch too.

Thank you the very good cooperation,

Attila

@hammera

hammera commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Cargo clippy related online workflow check produce exit code 101 error.
The log file show following, this is I think not related the hungarian tests related fix with I committed this day.
If this is not the case, please tell me what can me need fixing the affected test Rust files and I will doing the proper fix.
The log file output:

    Checking env_logger v0.11.11
error: casting to the same type is unnecessary (`u32` -> `u32`)
    --> src/speech.rs:2828:147
     |
2828 | ... unicode tables", char::from_u32(*ch).unwrap(), *ch as u32);
     |                                                    ^^^^^^^^^^ help: try: `{ *ch }`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#unnecessary_cast
     = note: `-D clippy::unnecessary-cast` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::unnecessary_cast)]`

error: could not compile `mathcat` (lib) due to 1 previous error
Error: Process completed with exit code 101.

Attila

@hammera

hammera commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

I synced my feature branch with the main repository, now more Github online workflow checks passed.
Very interesting, but after syncing the main branch and merge two branches with an interactive rebase, cargo test command shows me a failure with hungarian intent test in intent_prob_x function, without the left and right expression. If I ran only the cargo test Languages::hu command, the hungarian tests passed (perhaps a phantom failure because logging turned on the intent_prob_x function)?
After I commented out the init_logger(); function call into the hungarian intent.rs file intent_prob_x function, entire cargo test command pass successfull after branch syncing, and of course the normal cargo test Languages::hu test command pass too, produce wanted result the language tests.

Attila

@hammera
hammera force-pushed the hu branch 3 times, most recently from 9ea8047 to 3d634d8 Compare July 3, 2026 10:30
@hammera

hammera commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Now everithing looks fine, previous force-push operation not added with @NSoiffer june 29 doed clippy fix.
Now builds related online workflow checks are passed, the fuzzing related check require more time to run successfull (yesterday evening require about 45 minutes to ran).
So, following checks now ran successfull:

  • clippy lint check,
  • Rust build and test,
  • Python related check,
  • Rules directory zipping.
    Now still running the Fuzz / Build and fuzz (with MathML dict + corpus cache) online workflow check.

Attila

@hammera

hammera commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Very nice, now all online Github workflow checks are passed.

@hammera

hammera commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Don't surprise with force-push related, I doed only little cleanup my feature branch and squashed few commits during interactive rebase my feature branch. :-):-)
Progress status with optional hungarian unicode-full.yaml file translation revieving related work:
There are only 1784 untranslated messages left in the Hungarian unicode-full.yaml file. I still need to review these and mark the correct versions as translated messages. To avoid data loss and to keep the Hungarian development branch always in sync, I will upload the current Hungarian unicode-full.yaml file to the Hungarian development branch every evening.
I am trying to hurry up with this remaining translation task as much as possible so that the of this optional unicode-full.yaml file complete translation can be included in the final MathCAT version.

@hammera
hammera force-pushed the hu branch 6 times, most recently from 2a5fc23 to 46304d9 Compare July 15, 2026 19:48
@hammera
hammera force-pushed the hu branch 3 times, most recently from 54d0efe to 8aed5a9 Compare July 17, 2026 09:13
@hammera

hammera commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Boys, change anything in Rust stable version?
Previous days cargo clippy check are not failed, but when I update with rustup update command my Rust environment the latest stable update, cargo clippy command doesn't ran too my local machine, similar with online Github workflow related clippy check.
Into the online log I seeing following:

    Checking linked-hash-map v0.5.6
error: redundant reference in `format!` argument
  --> build.rs:47:98
   |
47 | ...                   format!("build.rs couldn't create {:?}: {}", &zip_name, e))),
   |                                                                    ^^^^^^^^^ help: remove the redundant `&`: `zip_name`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#useless_borrows_in_formatting
   = note: `-D clippy::useless-borrows-in-formatting` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::useless_borrows_in_formatting)]`

error: redundant reference in `println!` argument
   --> build.rs:163:74
    |
163 |             println!("cargo::warning=couldn't change to directory '{}'", &out_dir.display());
    |                                                                          ^^^^^^^^^^^^^^^^^^ help: remove the redundant `&`: `out_dir.display()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#useless_borrows_in_formatting

error: redundant reference in `panic!` argument
   --> build.rs:182:67
    |
182 |             Err(e) => panic!("build.rs couldn't create {:?}: {}", &archive_path.to_str(), e),
    |                                                                   ^^^^^^^^^^^^^^^^^^^^^^ help: remove the redundant `&`: `archive_path.to_str()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#useless_borrows_in_formatting

error: could not compile `mathcat` (build script) due to 3 previous errors
warning: build failed, waiting for other jobs to finish...
Error: Process completed with exit code 101.

I ran cargo clippy --fix --lib -p mathcat -- command, and cargo clippy --fix --lib -p mathcat -- --no-deps command.
I attaching the patch, but temporary committed this change too.
fix_clippy.patch

After Rust update and clippy suggested fixes, again my local system ran correct with cargo clippy, cargo build, cargo test, cargo check commands.

Now, into the unicode-full.yaml file remaining only with 686 untranslated messages.

Attila

@hammera

hammera commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Very fine, Rust Clippy lint check related online workflow now ran successfull again.

@hammera

hammera commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Very nice, final all other Github online checks are passed again.

NSoiffer and others added 24 commits July 29, 2026 09:38
In discussions with Anders, we are still trying to work out the rationale for why they do what they do. He said the spec may need to change to be less ad-hoc. In the meantime, no one has complained in 2 years. Also, many more tests need to be added.

The tests were turned off for two years by accident. They are now back on.
… there is no longer a need for user-defined typeform indicators. I removed the calls to look at those prefs. This fixes an issue with the fix for daisy#634 and the user prefs.yaml file.

I also updated the tests.
The fix is in the 'en', Nemeth, ASCIIMath, and LaTeX rules.
I've added tests for all of those for upto four `.`s.

This needs to propogate to other languages. Likely other braille codes need to change, but I'm not sure what should happen in the braille codes. UEB is correct.
Use a multipurpose indicator between a right superscript/subscript and a left superscript/subscript

Add some tests from the update for that case (some were already in the tests and the expected result was updated)
…ally is a chemical element that needs to be spelled out.

Update pausing in some tests due to the fix.
…rty translations

Correct some intersection large ops tests in Clearspeak and Simplespeak large operations tests
hammera added 4 commits July 29, 2026 21:50
…slations

Correct some alphabet test after unicode-full.yaml added cap string translations and script translation

Signed-off-by: Attila Hammer <hammera@pickup.hu>
…tream english rules synchronizations

Signed-off-by: Attila Hammer <hammera@pickup.hu>
… files cleanup

Signed-off-by: Attila Hammer <hammera@pickup.hu>
…ated messages hungarian translations

Signed-off-by: Attila Hammer <hammera@pickup.hu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

3 participants