Skip to content

chore(security): replace .trivyignore with VEX statements - #361

Open
dannysauer wants to merge 1 commit into
mainfrom
claude/trivyignore-to-vex
Open

dannysauer wants to merge 1 commit into
mainfrom
claude/trivyignore-to-vex

Conversation

@dannysauer

@dannysauer dannysauer commented Nov 4, 2026 •

Copy link
Copy Markdown
Owner

Summary

.trivyignore held two entries, and neither still applies. The first push on this branch emptied the file, and Security Scan (PR) scanned the image without it:

  • Debian packages: no HIGH or CRITICAL findings. CVE-2026-0861 (glibc memalign overflow) no longer appears. The image runs apt-get upgrade on every build, so a Debian fix would already be installed. I couldn't confirm the fix on Debian's security tracker from my session.
  • jaraco.context isn't in the image. GHSA-58pv-8j8x-9vj2 came in through the copy that setuptools vendors. The Dockerfile now removes setuptools and fails the build if it can still be imported.

This PR:

  • Deletes .trivyignore and the three trivyignores: inputs in ci.yml.
  • Records GHSA-58pv-8j8x-9vj2 in .openvex.json as not_affected with component_not_present, and explains why in the impact statement.
  • Leaves CVE-2026-0861's under_investigation statement in place until someone confirms the Debian fix.
  • Updates docs/vex.md and AGENTS.md: findings are recorded only in .openvex.json. An affected finding with no fix keeps failing Security Scan (PR) until a maintainer decides what to do, instead of being silenced.

Change type

  • feat: new behavior
  • fix: bug fix
  • docs: documentation
  • refactor: code structure
  • test: tests
  • chore: maintenance

Impact

  • Tests cover changed behavior, or the summary explains why they aren't needed. No code changes.
  • Public documentation matches the implementation
  • GitHub App permissions and events are unchanged or documented
  • stampbot.toml behavior is unchanged or documented
  • Helm values and templates are unchanged or documented
  • Deployment and rollback behavior is unchanged or documented
  • Secret handling, logs, metrics, and operator impact were reviewed

Checks

  • Security Scan (PR) with .trivyignore emptied: passed. Debian packages and every Python package scanned clean, and jaraco.context isn't in the package list.
  • make test: 476 passed.
  • SKIP=actionlint,helmlint,helm-kubeconform pre-commit run --all-files: passed. actionlint isn't installed in my session, so the workflow edit, which deletes three lines, relies on CI's lint.
  • The documentation review's findings are included.

Related issues

Follows #360.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Jc6x3m2t8YBrhUh7we64vu

@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f95eb6e) to head (d88892d).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #361   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines         1518      1518           
  Branches       190       190           
=========================================
  Hits          1518      1518           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

🐳 Docker image built and pushed: ghcr.io/dannysauer/stampbot:pr-1208bbd

@dannysauer
dannysauer force-pushed the claude/trivyignore-to-vex branch from 7e02455 to a18fa7a Compare November 4, 2026 06:44
Delete .trivyignore and the trivyignores inputs that pointed Trivy at
it. A scan with both entries removed found nothing: Debian packages had
no HIGH or CRITICAL findings, and jaraco.context is no longer in the
image because the Dockerfile removes setuptools, which vendored it.

Record GHSA-58pv-8j8x-9vj2 as not_affected with component_not_present.
CVE-2026-0861 keeps its under_investigation statement. Update docs/vex.md
and AGENTS.md: findings belong in .openvex.json, and an affected finding
with no fix should keep the scan red for a maintainer to decide.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jc6x3m2t8YBrhUh7we64vu
@dannysauer
dannysauer force-pushed the claude/trivyignore-to-vex branch from a18fa7a to d88892d Compare November 4, 2026 06:45
@dannysauer dannysauer changed the title chore(security): move .trivyignore entries to VEX chore(security): replace .trivyignore with VEX statements Nov 4, 2026
@dannysauer
dannysauer marked this pull request as ready for review November 4, 2026 06:45
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T06:46:36.472812Z d88892d Draft marked ready
🔒 Security Review ✅ Completed 2026-11-04T06:48:47.848234Z d88892d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

🐳 Docker image built and pushed: ghcr.io/dannysauer/stampbot:pr-0c6dada

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

🐳 Docker image built and pushed: ghcr.io/dannysauer/stampbot:pr-f956fc9

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants