docs: change examples to use pub APIs - #1961
Merged
Merged
Conversation
github-actions
Bot
added
package:cupertino_http
# Conflicts: # pkgs/cronet_http/CHANGELOG.md # pkgs/cronet_http/pubspec.yaml # pkgs/cupertino_http/CHANGELOG.md # pkgs/cupertino_http/pubspec.yaml # pkgs/ok_http/CHANGELOG.md
natebosch
approved these changes
Sep 14, 2026
|
|
||
| testWidgets('test search filters results', (WidgetTester tester) async { | ||
| final mockClient = MockClient((request) async { | ||
| if (request.url.path == '/api/package-name-completion-data') { |
Member
There was a problem hiding this comment.
I tried refactoring this chain into a switch on request.url.path and it ended up formatting worse 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The books API previously used by the
package:http,package:cronet_http,package:ok_http, andpackage:cupertino_httpexamples never has available quota so the examples appear broken.Switch the examples to use the Dart pub API.
The Flutter example in
package:cronet_httpandpackage:flutter_http_exampleis significantly more complex and looks like this:The examples for the other packages are fairly simple.
Contribution guidelines:
dart format.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.