Render automated bot actors as plain text in publish emails - #9575
Merged
Merged
Conversation
When packages are published via automated GitHub Actions OIDC authentication, automated bots such as `github-actions[bot]` do not have standard user profiles at `github.com/<actor>`. Generating profile links for them produces broken URLs like `https://github.com/github-actions%5Bbot%5D` which return 404. * Update `githubUserUrl` in `app/lib/shared/urls.dart` to return `null` for bot identities (e.g. `[bot]` suffix) or invalid usernames. * Update `createPackageUploadedEmail` in `app/lib/service/email/email_templates.dart` to display unlinked `@actor` in plain text and HTML emails when `actorUri` is `null`. * Add unit tests in `urls_test.dart` and `email_templates_test.dart`.
Member
Author
|
Follow-up to #9558 (commit b9c64c0). When packages are published via automated GitHub Actions workflows, the OIDC |
isoos
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When packages are published via automated GitHub Actions OIDC authentication, automated bots such as
github-actions[bot]do not have standard user profiles atgithub.com/<actor>. Generating profile links for them produces broken URLs likehttps://github.com/github-actions%5Bbot%5Dwhich return 404.githubUserUrlinapp/lib/shared/urls.dartto returnnullfor bot identities (e.g.[bot]suffix) or invalid usernames.createPackageUploadedEmailinapp/lib/service/email/email_templates.dartto display unlinked@actorin plain text and HTML emails whenactorUriisnull.urls_test.dartandemail_templates_test.dart.